From 4eade766d24a6c88bdb607b5ad13a064473a7982 Mon Sep 17 00:00:00 2001 From: Derek Ho Date: Thu, 18 Jul 2024 16:38:07 -0400 Subject: [PATCH] Fix lint and tests Signed-off-by: Derek Ho --- .../apps/configuration/panels/tenant-list/configure_tab1.tsx | 2 +- public/apps/configuration/panels/tenant-list/manage_tab.tsx | 3 ++- public/apps/configuration/panels/tenant-list/tenant-list.tsx | 2 +- .../panels/tenant-list/test/tenant-list.test.tsx | 3 +++ .../configuration/test/__snapshots__/app-router.test.tsx.snap | 1 - public/apps/configuration/test/app-router.test.tsx | 4 ++++ 6 files changed, 11 insertions(+), 4 deletions(-) diff --git a/public/apps/configuration/panels/tenant-list/configure_tab1.tsx b/public/apps/configuration/panels/tenant-list/configure_tab1.tsx index b38f0a098..770496d85 100644 --- a/public/apps/configuration/panels/tenant-list/configure_tab1.tsx +++ b/public/apps/configuration/panels/tenant-list/configure_tab1.tsx @@ -52,7 +52,7 @@ import { import { getDashboardsInfo } from '../../../../utils/dashboards-info-utils'; import { LOCAL_CLUSTER_ID } from '../../../../../common'; import { AccessErrorComponent } from '../../access-error-component'; -import { LocalCluster } from '../../app-router'; +import { LocalCluster } from '../../../../utils/datasource-utils'; export function ConfigureTab1(props: AppDependencies) { const [isMultiTenancyEnabled, setIsMultiTenancyEnabled] = useState(false); diff --git a/public/apps/configuration/panels/tenant-list/manage_tab.tsx b/public/apps/configuration/panels/tenant-list/manage_tab.tsx index 544aff698..ab30bf0ee 100644 --- a/public/apps/configuration/panels/tenant-list/manage_tab.tsx +++ b/public/apps/configuration/panels/tenant-list/manage_tab.tsx @@ -69,7 +69,8 @@ import { useContextMenuState } from '../../utils/context-menu'; import { generateResourceName } from '../../utils/resource-utils'; import { DocLinks } from '../../constants'; import { TenantList } from './tenant-list'; -import { LocalCluster, getBreadcrumbs } from '../../app-router'; +import { getBreadcrumbs } from '../../app-router'; +import { LocalCluster } from '../../../../utils/datasource-utils'; import { buildUrl } from '../../utils/url-builder'; import { CrossPageToast } from '../../cross-page-toast'; import { getDashboardsInfo } from '../../../../utils/dashboards-info-utils'; diff --git a/public/apps/configuration/panels/tenant-list/tenant-list.tsx b/public/apps/configuration/panels/tenant-list/tenant-list.tsx index c624adcbe..cebfb4981 100644 --- a/public/apps/configuration/panels/tenant-list/tenant-list.tsx +++ b/public/apps/configuration/panels/tenant-list/tenant-list.tsx @@ -30,7 +30,7 @@ import { AppDependencies } from '../../../types'; import { ExternalLink } from '../../utils/display-utils'; import { DocLinks } from '../../constants'; import { getDashboardsInfo } from '../../../../utils/dashboards-info-utils'; -import { LocalCluster } from '../../app-router'; +import { LocalCluster } from '../../../../utils/datasource-utils'; import { SecurityPluginTopNavMenu } from '../../top-nav-menu'; interface TenantListProps extends AppDependencies { diff --git a/public/apps/configuration/panels/tenant-list/test/tenant-list.test.tsx b/public/apps/configuration/panels/tenant-list/test/tenant-list.test.tsx index ca4081fce..66117c398 100644 --- a/public/apps/configuration/panels/tenant-list/test/tenant-list.test.tsx +++ b/public/apps/configuration/panels/tenant-list/test/tenant-list.test.tsx @@ -64,6 +64,9 @@ describe('Tenant list', () => { setBreadcrumbs() { return 1; }, + navGroup: { + getNavGroupEnabled: jest.fn().mockReturnValue(false), + }, }, }; const config = { diff --git a/public/apps/configuration/test/__snapshots__/app-router.test.tsx.snap b/public/apps/configuration/test/__snapshots__/app-router.test.tsx.snap index 21aa4e515..d5ee503be 100644 --- a/public/apps/configuration/test/__snapshots__/app-router.test.tsx.snap +++ b/public/apps/configuration/test/__snapshots__/app-router.test.tsx.snap @@ -495,7 +495,6 @@ exports[`SecurityPluginTopNavMenu renders DataSourceMenu when dataSource is enab diff --git a/public/apps/configuration/test/app-router.test.tsx b/public/apps/configuration/test/app-router.test.tsx index 540f44614..4bb61888d 100644 --- a/public/apps/configuration/test/app-router.test.tsx +++ b/public/apps/configuration/test/app-router.test.tsx @@ -20,6 +20,7 @@ import { getDataSourceFromUrl } from '../../../utils/datasource-utils'; jest.mock('../../../utils/datasource-utils', () => ({ getDataSourceFromUrl: jest.fn(), + LocalCluster: { id: '', label: 'Local cluster' }, })); describe('SecurityPluginTopNavMenu', () => { @@ -30,6 +31,9 @@ describe('SecurityPluginTopNavMenu', () => { notifications: jest.fn(), chrome: { setBreadcrumbs: jest.fn(), + navGroup: { + getNavGroupEnabled: jest.fn().mockReturnValue(false), + }, }, };