for loop with multiline iteration has incorrect indention for closing brace

[tmccombs]

If the iteration part of a for loop is multiple lines, for example:

for {
  a <- b
  c <- d
} yield {
   // body
}

then when I type the second opening brace (after yield) it iwll indent the line so the first closing brace lines up with the line before, like:

for {
  a <- b
  c <- d
  } yield {

The same thing happens if the yield isn't there. Strangely , if I don't have the second opening brace the line with the closing brace indents correctly.

[stumash]

this also happens for function definitions, i.e. should do:

def foo(
  i: Int,
  j: Int,
): Int = {
  // body
}

but actually does:

def foo(
  i: Int,
  j: Int,
  ): Int = {
  // body
}

In fact, the exact same problem also exists for function calls, not only function definitions. I.e., it does this:

foo(
  1,
  2,
  ) // should not be indented

I went ahead and looked at indent/scala.vim to propose a fix, but vimscript man... helluva language

[merijn]

I know this is 4 years late, but since this problem frustrates me a ton I've been digging through indent/scala.vim and at least I know why it goes wrong. IFF you have a trailing comma scala#LineEndsInIncomplete returns out of GetScalaIndent before it ever reaches the code to dedent on a closing parenthesis. Unfortunately, GetScalaIndent is...rather convoluted and the logic for WHY things are checked in the order they are is...non-existent, so I'm not entirely sure on the best way to fix it (yet)