Merge pull request #106 from deriv-com/fix--position-icon-on-dark-theme

farabi-deriv · web-flow · commit 7900b4b60243 · 2025-03-21T17:54:06.000+08:00
fix: position icon and filter dropdown padding
diff --git a/src/components/PositionComponents/PositionEmptyState.tsx b/src/components/PositionComponents/PositionEmptyState.tsx
@@ -8,7 +8,7 @@ interface PositionEmptyStateProps {
 }
 
 export const PositionEmptyState: React.FC<PositionEmptyStateProps> = ({
-    icon = <StandaloneBriefcaseFillIcon fill="#0000003D" iconSize="2xl" />,
+    icon = <StandaloneBriefcaseFillIcon fill="#D1D5DB" iconSize="2xl" />,
     positionType,
     className = "flex items-center justify-center",
 }) => {
diff --git a/src/components/Sidebar/positions/components/FilterDropdown.tsx b/src/components/Sidebar/positions/components/FilterDropdown.tsx
@@ -41,7 +41,7 @@ export const FilterDropdown: FC<FilterDropdownProps> = ({
             onMouseDown={(event) => event.stopPropagation()}
         >
             <button
-                className="text-sm h-9 w-full p-2 bg-theme border border-theme rounded-full text-theme-muted flex items-center justify-between"
+                className="text-sm h-9 w-full pl-4 pr-2 bg-theme border border-theme rounded-full text-theme-muted flex items-center justify-between"
                 onClick={() => setDropdownOpen(!dropdownOpen)}
             >
                 <span>{selectedFilter}</span>

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ interface PositionEmptyStateProps {`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`export const PositionEmptyState: React.FC<PositionEmptyStateProps> = ({`
`11`		`- icon = <StandaloneBriefcaseFillIcon fill="#0000003D" iconSize="2xl" />,`
	`11`	`+ icon = <StandaloneBriefcaseFillIcon fill="#D1D5DB" iconSize="2xl" />,`
`12`	`12`	`positionType,`
`13`	`13`	`className = "flex items-center justify-center",`
`14`	`14`	`}) => {`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export const FilterDropdown: FC<FilterDropdownProps> = ({`
`41`	`41`	`onMouseDown={(event) => event.stopPropagation()}`
`42`	`42`	`>`
`43`	`43`	`<button`
`44`		`- className="text-sm h-9 w-full p-2 bg-theme border border-theme rounded-full text-theme-muted flex items-center justify-between"`
	`44`	`+ className="text-sm h-9 w-full pl-4 pr-2 bg-theme border border-theme rounded-full text-theme-muted flex items-center justify-between"`
`45`	`45`	`onClick={() => setDropdownOpen(!dropdownOpen)}`
`46`	`46`	`>`
`47`	`47`	`<span>{selectedFilter}</span>`