chore: revert mobx-utils dependency and refactor portfolio store (#17919

)
deriv-com · Dec 31, 2024 · 4b4907c · 4b4907c
1 parent 8863579
commit 4b4907c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -137,6 +137,7 @@
         "lodash.throttle": "^4.1.1",
         "mobx": "^6.6.1",
         "mobx-react-lite": "^3.4.0",
+        "mobx-utils": "^6.0.5",
         "moment": "^2.29.2",
         "null-loader": "^4.0.1",
         "object.fromentries": "^2.0.0",

diff --git a/packages/core/src/Stores/portfolio-store.js b/packages/core/src/Stores/portfolio-store.js
@@ -1,5 +1,6 @@
 import throttle from 'lodash.throttle';
 import { action, computed, makeObservable, observable, override, reaction } from 'mobx';
+import { computedFn } from 'mobx-utils';
 
 import { Money } from '@deriv/components';
 import {
@@ -57,7 +58,7 @@ export default class PortfolioStore extends BaseStore {
 
     active_positions = [];
 
-    getPositionByIdCache = observable.map();
+    getPositionById = computedFn(id => this.positions.find(position => +position.id === +id));
 
     constructor(root_store) {
         // TODO: [mobx-undecorate] verify the constructor arguments and the arguments of this automatically generated super call
@@ -110,17 +111,6 @@ export default class PortfolioStore extends BaseStore {
         this.root_store = root_store;
     }
 
-    getPositionById(id) {
-        // Check if we already have a cached position for the given ID.
-        if (!this.getPositionByIdCache.has(id)) {
-            // Compute the position and store it in the cache.
-            const position = this.positions.find(position => +position.id === +id);
-            this.getPositionByIdCache.set(id, position);
-        }
-
-        return this.getPositionByIdCache.get(id);
-    }
-
     async initializePortfolio() {
         if (this.has_subscribed_to_poc_and_transaction) {
             this.clearTable();
@@ -594,9 +584,6 @@ export default class PortfolioStore extends BaseStore {
     }
 
     updatePositions = () => {
-        // Whenever positions are updated, clear the cache to ensure consistency.
-        this.getPositionByIdCache.clear();
-
         this.responseQueue.forEach(res => this.proposalOpenContractHandler(res));
         this.responseQueue = [];
         this.setActivePositions();

diff --git a/packages/trader/package.json b/packages/trader/package.json
@@ -114,6 +114,7 @@
         "lodash.throttle": "^4.1.1",
         "mobx": "^6.6.1",
         "mobx-react-lite": "^3.4.0",
+        "mobx-utils": "^6.0.5",
         "moment": "^2.29.2",
         "null-loader": "^4.0.1",
         "prop-types": "^15.7.2",