Akmal / feat: re-trigger barrier validation to show any error message…

…s hidden that were hidden behind th e action sheet (#17571) * feat: re-trigger barrier validation to show any error messages hidden that were hidden * chore: update quill-ui librare * chore: update quill version * chore: recreate package-lock * fix: merge conflict? * chore: regenerate package-lock and revert pre-commit change in app.tsx * chore: regenerate package-lock and revert pre-commit change in app.tsx * fix: remove artificial delay from ServicesErrorSnackbar
deriv-com · Dec 23, 2024 · f81e450 · f81e450
1 parent 1bfe4a9
commit f81e450
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/trader/src/AppV2/Components/ServicesErrorSnackbar/services-error-snackbar.tsx b/packages/trader/src/AppV2/Components/ServicesErrorSnackbar/services-error-snackbar.tsx
@@ -9,8 +9,6 @@ import useContractDetails from 'AppV2/Hooks/useContractDetails';
 import { checkIsServiceModalError, SERVICE_ERROR } from 'AppV2/Utils/layout-utils';
 import { getDisplayedContractTypes } from 'AppV2/Utils/trade-types-utils';
 
-const PROLONGATED_DURATION = 8000;
-
 const ServicesErrorSnackbar = observer(() => {
     const {
         common: { services_error, resetServicesError },
@@ -51,7 +49,6 @@ const ServicesErrorSnackbar = observer(() => {
             : '48px';
     const action_props = {
         actionText: localize('View'),
-        delay: PROLONGATED_DURATION,
         onActionClick: () => window.open(getStaticUrl('tnc/trading-terms.pdf', true)),
     };
 

diff --git a/packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx b/packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx
@@ -181,6 +181,11 @@ const BarrierInput = observer(
                         onAction: () => {
                             if (validation_errors.barrier_1.length === 0) {
                                 onClose(true);
+
+                                // This is a workaround to re-trigger any validation errors that were hidden behind the action sheet
+                                handleOnChange({
+                                    target: { name: 'barrier_1', value: barrier_1.replace(/[+-]/g, '') },
+                                });
                             } else {
                                 setShouldShowError(true);
                             }