Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM] evgeniy/suisin/utkarsha/upm-393/ add Passkeys for responsive #12587

Merged
merged 171 commits into from
Apr 1, 2024

Conversation

yauheni-deriv
Copy link
Contributor

@yauheni-deriv yauheni-deriv commented Dec 28, 2023

Changes:

This PR is related to phase 1 of implementation 'Passkeys'.
First we provide this feature only for responsive and native mobile app.
For easy handling with WebAuth on both FE and BE we use 'simplewebauthn' library.
First phase includes only passkeys creation in account settings and login functionality with existing key (the login page is on BE side).
Added new pages, dynamic routes configuring, feature enabling on from growthbook.

Screenshots:

Screenshot 2024-01-25 at 15 42 10
passkey_demo.mov

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 1, 2024 8:26am

Copy link
Contributor

github-actions bot commented Dec 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12587](https://github.com/binary-com/deriv-app/pull/12587)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-upmpasskeysadd.binary.sx?qa_server=red.derivws.com&app_id=31586
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-upmpasskeysadd.binary.sx
- **App ID**: `31586`

Copy link
Contributor

github-actions bot commented Dec 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-upmpasskeysadd.binary.sx/

Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.7% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Generating Lighthouse report...

@amina-deriv amina-deriv merged commit 6462558 into deriv-com:master Apr 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.