Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA] / DRAFT/ Kate / DTRA-497 / Trade Type section Updates #12984

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Jan 16, 2024

Changes:

  • Moved Higher/Lower contract type in Trade types menu under Ups & Downs.
  • Added 'Learn about this trade type(s)' button to the Trade type widget and added functionality for opening description section from there (for a specific contract).
  • Added dropdown with contract types list for navigation between different description. Removed info icons from trade type menu. For unavailable contract type description reused info banner and added disabled mode.
  • Expanded functionality of existing components.
  • Added and refactored tests.
  • Updated analytics

Screenshots:

Screenshot 2024-01-20 at 21 06 36 Screenshot 2024-01-22 at 09 17 43 Screenshot 2024-01-20 at 21 06 43 Screenshot 2024-01-20 at 21 08 11 Screenshot 2024-01-20 at 21 06 59 Screenshot 2024-01-20 at 21 07 31 Screenshot 2024-01-20 at 21 07 38

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 5, 2024 9:49am

Copy link

sweep-ai bot commented Jan 16, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

Copy link
Contributor

github-actions bot commented Jan 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12984](https://github.com/binary-com/deriv-app/pull/12984)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-497descriptionfu-f6dee8.binary.sx?qa_server=red.derivws.com&app_id=38672
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-497descriptionfu-f6dee8.binary.sx
- **App ID**: `38672`

Copy link
Contributor

github-actions bot commented Jan 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-497descriptionfu-f6dee8.binary.sx/

@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 35.034% (+0.07%) from 34.963%
when pulling 12186b1 on kate-deriv:kate/DTRA-497/description_functionality_updates
into e8bf59f on binary-com:master.

maryia-deriv
maryia-deriv previously approved these changes Jan 24, 2024
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

@balakrishna-deriv balakrishna-deriv merged commit d0f21f2 into deriv-com:master Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants