Arshad/ COJ-481 / Address Fields #13074

arshad-rao-deriv · 2024-01-22T09:22:02Z

Changes:

Added FormInputField.
Added FormDropdownField.
Added AddressFields with validations

Screenshots:

vercel · 2024-01-22T09:22:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Jan 30, 2024 2:25pm

github-actions · 2024-01-22T09:39:01Z

A production App ID was automatically generated for this PR. (log)

PR: Arshad/ COJ-481 / Address Fields #13074
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-arshad-rao-deriv-arshad-coj-481addres-44dbb7.binary.sx?qa_server=red.derivws.com&app_id=23880
- Original: https://deriv-app-git-fork-arshad-rao-deriv-arshad-coj-481addres-44dbb7.binary.sx
App ID: 23880

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/13074](https://github.com/binary-com/deriv-app/pull/13074)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-arshad-rao-deriv-arshad-coj-481addres-44dbb7.binary.sx?qa_server=red.derivws.com&app_id=23880
    - **Original**: https://deriv-app-git-fork-arshad-rao-deriv-arshad-coj-481addres-44dbb7.binary.sx
- **App ID**: `23880`

github-actions · 2024-01-22T09:39:15Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	88
🟢 Best practices	92
🟢 SEO	92
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-arshad-rao-deriv-arshad-coj-481addres-44dbb7.binary.sx/

coveralls · 2024-01-22T09:42:45Z

coverage: 34.991% (-0.007%) from 34.998%
when pulling 692abd7 on arshad-rao-deriv:Arshad/COJ-481/AddressDetailsFields
into 9eda787 on binary-com:master.

packages/account-v2/src/modules/AddressFields/AddressFields.tsx

packages/account-v2/src/modules/AddressFields/validations.ts

packages/account-v2/src/components/base/WalletDropdown/WalletDropdown.scss

packages/api/src/hooks/useStatesList.ts

packages/account-v2/src/modules/AddressFields/AddressFields.tsx

packages/account-v2/src/modules/AddressFields/validations.ts

amina-deriv · 2024-01-23T06:07:22Z

packages/account-v2/src/modules/AddressFields/validations.ts

+        }),
+    addressPostcode: Yup.string()
+        .max(20, 'Please enter a postal/ZIP code under 20 characters.')
+        .matches(regexChecks.address_details.address_postcode, 'Letters, numbers, spaces, hyphens only')


we dont have localize in v2 packages for now @suisin-deriv

packages/account-v2/src/modules/AddressFields/validations.ts

packages/account-v2/src/modules/AddressFields/AddressFields.tsx

amina-deriv

LGTM

sonarqubecloud · 2024-01-30T14:07:57Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-01-30T14:29:11Z

⏳ Generating Lighthouse report...

arshad-rao-deriv added 4 commits January 22, 2024 13:19

feat: added formInputfield to accounts v2

a19445c

feat: Added formdropdownfield to accounts v2

cc9703b

feat: added address field validations

f45c183

feat: Added address fields in account v2 package

9aa50b4

arshad-rao-deriv requested review from adrienne-deriv, thisyahlen-deriv, farhan-nurzi-deriv, azmib-developer, balakrishna-deriv and yashim-deriv as code owners January 22, 2024 09:22

arshad-rao-deriv temporarily deployed to Preview January 22, 2024 09:22 — with GitHub Actions Inactive

arshad-rao-deriv changed the title ~~Arshad/ coj 481/address details fields~~ Arshad/ COJ-481 / Address Fields Jan 22, 2024

fix: Make the options parameter optional in useStatesList

f0a3e1f

arshad-rao-deriv temporarily deployed to Preview January 22, 2024 09:38 — with GitHub Actions Inactive

shaheer-deriv approved these changes Jan 22, 2024

View reviewed changes

amina-deriv reviewed Jan 22, 2024

View reviewed changes

packages/account-v2/src/modules/AddressFields/AddressFields.tsx Outdated Show resolved Hide resolved

amina-deriv reviewed Jan 22, 2024

View reviewed changes

packages/account-v2/src/modules/AddressFields/validations.ts Outdated Show resolved Hide resolved

amina-deriv reviewed Jan 22, 2024

View reviewed changes

packages/account-v2/src/modules/AddressFields/validations.ts Show resolved Hide resolved

likhith-deriv reviewed Jan 23, 2024

View reviewed changes

suisin-deriv reviewed Jan 23, 2024

View reviewed changes

packages/account-v2/src/modules/AddressFields/validations.ts Outdated Show resolved Hide resolved

amina-deriv reviewed Jan 23, 2024

View reviewed changes

suisin-deriv reviewed Jan 23, 2024

View reviewed changes

packages/account-v2/src/modules/AddressFields/validations.ts Show resolved Hide resolved

yauheni-deriv reviewed Jan 23, 2024

View reviewed changes

packages/account-v2/src/modules/AddressFields/AddressFields.tsx Show resolved Hide resolved

refactor: Append tests, refactor constants

2fd8524

chore: update deriv-com/ui package version

86edb3d

arshad-rao-deriv had a problem deploying to Preview January 23, 2024 09:55 — with GitHub Actions Failure

chore: change deriv ui package version

28a9a0f

vercel bot had a problem deploying to Preview January 23, 2024 12:45 Failure

Merge branch 'master' into arshad/COJ-481/AddressDetailsFields

2896b6d

arshad-rao-deriv had a problem deploying to Preview January 23, 2024 19:51 — with GitHub Actions Failure

arshad-rao-deriv temporarily deployed to Preview January 23, 2024 19:51 — with GitHub Actions Inactive

Merge branch 'master' into arshad/COJ-481/AddressDetailsFields

7917fd6

arshad-rao-deriv temporarily deployed to Preview January 24, 2024 06:14 — with GitHub Actions Inactive

fix: fix regex for postcode

531bdbf

arshad-rao-deriv had a problem deploying to Preview January 24, 2024 06:55 — with GitHub Actions Failure

arshad-rao-deriv temporarily deployed to Preview January 24, 2024 06:55 — with GitHub Actions Inactive

Merge branch 'master' into arshad/COJ-481/AddressDetailsFields

d96bb80

arshad-rao-deriv had a problem deploying to Preview January 24, 2024 07:12 — with GitHub Actions Failure

arshad-rao-deriv temporarily deployed to Preview January 24, 2024 07:12 — with GitHub Actions Inactive

Merge branch 'master' into arshad/COJ-481/AddressDetailsFields

b21b2b7

arshad-rao-deriv temporarily deployed to Preview January 24, 2024 09:56 — with GitHub Actions Inactive

amina-deriv previously approved these changes Jan 24, 2024

View reviewed changes

arshad-rao-deriv added 2 commits January 30, 2024 16:42

Merge branch 'master' into Arshad/COJ-481/AddressDetailsFields

b1d36a2

refactor: export modules and useKycAuthStatus hook

692abd7

arshad-rao-deriv dismissed amina-deriv’s stale review via 692abd7 January 30, 2024 14:05

arshad-rao-deriv temporarily deployed to Preview January 30, 2024 14:06 — with GitHub Actions Inactive

likhith-deriv approved these changes Jan 30, 2024

View reviewed changes

likhith-deriv merged commit 6d6a945 into deriv-com:master Jan 30, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arshad/ COJ-481 / Address Fields #13074

Arshad/ COJ-481 / Address Fields #13074

arshad-rao-deriv commented Jan 22, 2024 •

edited

Loading

vercel bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Jan 22, 2024 •

edited

Loading

coveralls commented Jan 22, 2024 •

edited

Loading

amina-deriv Jan 23, 2024

amina-deriv left a comment

sonarqubecloud bot commented Jan 30, 2024

github-actions bot commented Jan 30, 2024

Arshad/ COJ-481 / Address Fields #13074

Arshad/ COJ-481 / Address Fields #13074

Conversation

arshad-rao-deriv commented Jan 22, 2024 • edited Loading

Changes:

Screenshots:

vercel bot commented Jan 22, 2024 • edited Loading

github-actions bot commented Jan 22, 2024 • edited Loading

github-actions bot commented Jan 22, 2024 • edited Loading

coveralls commented Jan 22, 2024 • edited Loading

amina-deriv Jan 23, 2024

Choose a reason for hiding this comment

amina-deriv left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 30, 2024

Quality Gate passed

github-actions bot commented Jan 30, 2024

arshad-rao-deriv commented Jan 22, 2024 •

edited

Loading

vercel bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Jan 22, 2024 •

edited

Loading

coveralls commented Jan 22, 2024 •

edited

Loading