Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Sergei / TRAH - 2265 / Regulation table #13075

Merged

Conversation

sergei-deriv
Copy link
Contributor

Changes:

  • Add regulation table for desktop and responsive

Card:

https://app.clickup.com/t/20696747/TRAH-2265

Screenshots/Video:

desktop:

image

mobile:

Screen.Recording.2024-01-22.at.12.23.39.mov

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 24, 2024 6:57am

Copy link
Contributor

github-actions bot commented Jan 22, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13075](https://github.com/binary-com/deriv-app/pull/13075)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2265regulati-c1b031.binary.sx?qa_server=red.derivws.com&app_id=24219
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2265regulati-c1b031.binary.sx
- **App ID**: `24219`

Copy link
Contributor

github-actions bot commented Jan 22, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-2265regulati-c1b031.binary.sx/

@coveralls
Copy link

coveralls commented Jan 22, 2024

Coverage Status

coverage: 34.815%. remained the same
when pulling 8b04a14 on sergei-deriv:sergei/trah-2265/regulation-table
into 3bcb266 on binary-com:master.

@sergei-deriv sergei-deriv changed the title Sergei / TRAH - 2265 / Regulation table [TRAH] Sergei / TRAH - 2265 / Regulation table Jan 22, 2024
@aizad-deriv aizad-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 23, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
4.5% Duplication on New Code

See analysis details on SonarCloud

@matin-deriv matin-deriv merged commit d4f39dc into deriv-com:master Jan 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants