Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Account-v2] Shaheer / COJ-505 / Single time initialization of onfido #13102

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

shaheer-deriv
Copy link
Contributor

@shaheer-deriv shaheer-deriv commented Jan 23, 2024

Changes:

  • Modified the if condition in loadOnfidoSdkScript to fix the logical error.
  • Wrapped initOnfido and loadOnfidoSdkScript in useCallback.
  • Added missing items in the dependency array

Screenshots:

Screenshot 2024-01-26 at 10 08 34 AM

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 26, 2024 5:41am

Copy link
Contributor

github-actions bot commented Jan 23, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13102](https://github.com/binary-com/deriv-app/pull/13102)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shaheer-deriv-shaheer-coj-505.binary.sx?qa_server=red.derivws.com&app_id=38788
    - **Original**: https://deriv-app-git-fork-shaheer-deriv-shaheer-coj-505.binary.sx
- **App ID**: `38788`

Copy link
Contributor

github-actions bot commented Jan 23, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shaheer-deriv-shaheer-coj-505.binary.sx/

@coveralls
Copy link

coveralls commented Jan 25, 2024

Coverage Status

coverage: 34.877% (+0.001%) from 34.876%
when pulling e84e540 on shaheer-deriv:shaheer/COJ-505
into 8ea415b on binary-com:master.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Generating Lighthouse report...

@shaheer-deriv shaheer-deriv marked this pull request as ready for review January 26, 2024 06:35
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@likhith-deriv likhith-deriv merged commit 7aa2710 into deriv-com:master Jan 29, 2024
6 checks passed
@shaheer-deriv shaheer-deriv deleted the shaheer/COJ-505 branch February 7, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants