-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DTRA] Maryia/DTRA-739/Add tooltips for Take profit & Stop loss in ContractUpdateForm #13103
[DTRA] Maryia/DTRA-739/Add tooltips for Take profit & Stop loss in ContractUpdateForm #13103
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-dtra-739tooltips-76e4cc.binary.sx/ |
…DTRA-739/tooltips-take-profit-stop-loss
Changes unknown |
…DTRA-739/tooltips-take-profit-stop-loss
tooltip_label={tooltip_text} | ||
tooltip_label={ | ||
<Localize i18n_default_text='When your profit reaches or exceeds this amount, your trade will be closed automatically.' /> | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unification of 'Take profit' text for all trade types everywhere including this one displayed in Trade params section.
…DTRA-739/tooltips-take-profit-stop-loss
|
⏳ Generating Lighthouse report... |
Changes:
Also:
connectWithContractUpdate
function,ToggleCardDialog
,Input
component by usingText
component instead of CSS font styles.Screenshots:
Before:
After: