Skip to content

Commit 11a07ac

Browse files
authored
hamed/improve_test_coverage (#265)
- improve test coverage
1 parent 198ac7c commit 11a07ac

File tree

266 files changed

+1208
-1018
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

266 files changed

+1208
-1018
lines changed

example/lib/blocs/active_symbols/active_symbols_bloc.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class ActiveSymbolsBloc extends Bloc<ActiveSymbolsEvent, ActiveSymbolsState> {
2828
try {
2929
final ActiveSymbolsResponse symbols = await _fetchActiveSymbols();
3030
emit(ActiveSymbolsLoaded(activeSymbols: symbols.activeSymbols!));
31-
} on ActiveSymbolsException catch (error) {
31+
} on BaseAPIException catch (error) {
3232
emit(ActiveSymbolsError(error.message));
3333
}
3434
}

example/lib/blocs/available_contracts/available_contracts_bloc.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class AvailableContractsBloc
4747
await _fetchAvailableContracts(event.activeSymbol);
4848

4949
emit(AvailableContractsLoaded(contracts: contracts.contractsFor!));
50-
} on ContractsForSymbolException catch (error) {
50+
} on BaseAPIException catch (error) {
5151
emit(AvailableContractsError(error.message));
5252
}
5353
}

example/lib/blocs/price_proposal/price_proposal_bloc.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class PriceProposalBloc extends Bloc<PriceProposalEvent, PriceProposalState> {
4444
await _unsubscribeProposal();
4545

4646
_subscribeProposal(event)
47-
.handleError((dynamic error) => error is ContractOperationException
47+
.handleError((dynamic error) => error is BaseAPIException
4848
? add(YieldError(error.message))
4949
: add(YieldError(error.toString())))
5050
.listen((ProposalResponse? proposal) =>

example/lib/blocs/ticks/ticks_bloc.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class TicksBloc extends Bloc<TicksEvent, TicksState> {
4040
await _unsubscribeTick();
4141

4242
_subscribeTick(event.selectedSymbol!)
43-
.handleError((dynamic error) => error is TickException
43+
.handleError((dynamic error) => error is BaseAPIException
4444
? add(YieldError(error.message))
4545
: add(YieldError(error.toString())))
4646
.listen((TicksResponse? tick) => add(YieldTick(tick)));

lib/api/exceptions/account_currency_exception.dart

-11
This file was deleted.

lib/api/exceptions/account_exception.dart

-10
This file was deleted.

lib/api/exceptions/account_limits_exception.dart

-11
This file was deleted.

lib/api/exceptions/account_settings_exception.dart

-11
This file was deleted.

lib/api/exceptions/account_status_exception.dart

-11
This file was deleted.

lib/api/exceptions/active_symbols_exception.dart

-11
This file was deleted.

lib/api/exceptions/api_token_exception.dart

-11
This file was deleted.

lib/api/exceptions/app_exception.dart

-10
This file was deleted.

lib/api/exceptions/asset_index_exception.dart

-11
This file was deleted.

lib/api/exceptions/authorize_exception.dart

-11
This file was deleted.

lib/api/exceptions/balance_exception.dart

-11
This file was deleted.

lib/api/exceptions/api_base_exception.dart renamed to lib/api/exceptions/base_api_exception.dart

+4-8
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@ import 'dart:developer' as dev;
33
import 'package:flutter_deriv_api/api/models/base_exception_model.dart';
44

55
/// Base exception class for all API exceptions.
6-
class APIBaseException implements Exception {
7-
/// Initializes
8-
APIBaseException({
9-
required this.baseExceptionModel,
10-
});
6+
class BaseAPIException implements Exception {
7+
/// Initializes an exception with the given [baseExceptionModel].
8+
BaseAPIException({required this.baseExceptionModel});
119

1210
/// Exception code and message model from API response.
1311
final BaseExceptionModel? baseExceptionModel;
@@ -23,9 +21,7 @@ class APIBaseException implements Exception {
2321

2422
@override
2523
String toString() {
26-
dev.log(
27-
'$runtimeType(code: $code, message: $message)',
28-
);
24+
dev.log('$runtimeType(code: $code, message: $message)');
2925

3026
return message ?? '$runtimeType: API unknown error.';
3127
}

lib/api/exceptions/cashier_exception.dart

-10
This file was deleted.

lib/api/exceptions/common_exception.dart

-10
This file was deleted.

lib/api/exceptions/contract_exception.dart

-10
This file was deleted.

lib/api/exceptions/contract_for_symbol_exception.dart

-10
This file was deleted.

lib/api/exceptions/contract_operations_exception.dart

-10
This file was deleted.

lib/api/exceptions/copy_trading_exception.dart

-11
This file was deleted.

lib/api/exceptions/exceptions.dart

+1-50
Original file line numberDiff line numberDiff line change
@@ -1,51 +1,2 @@
11
export '../models/base_exception_model.dart';
2-
export 'account_currency_exception.dart';
3-
export 'account_exception.dart';
4-
export 'account_limits_exception.dart';
5-
export 'account_settings_exception.dart';
6-
export 'account_status_exception.dart';
7-
export 'active_symbols_exception.dart';
8-
export 'api_base_exception.dart';
9-
export 'api_token_exception.dart';
10-
export 'app_exception.dart';
11-
export 'asset_index_exception.dart';
12-
export 'authorize_exception.dart';
13-
export 'balance_exception.dart';
14-
export 'cashier_exception.dart';
15-
export 'common_exception.dart';
16-
export 'contract_exception.dart';
17-
export 'contract_for_symbol_exception.dart';
18-
export 'contract_operations_exception.dart';
19-
export 'copy_trading_exception.dart';
20-
export 'exchange_exception.dart';
21-
export 'financial_assessment_exception.dart';
22-
export 'forget_exception.dart';
23-
export 'landing_company_exception.dart';
24-
export 'mt5_exception.dart';
25-
export 'new_account_exception.dart';
26-
export 'p2p_advert_exception.dart';
27-
export 'p2p_advertiser_exception.dart';
28-
export 'p2p_advertiser_stats_exception.dart';
29-
export 'p2p_chat_exception.dart';
30-
export 'p2p_exception.dart';
31-
export 'p2p_order_exception.dart';
32-
export 'payment_agent_exception.dart';
33-
export 'payment_exception.dart';
34-
export 'payout_currency_exception.dart';
35-
export 'ping_exception.dart';
36-
export 'portfolio_exception.dart';
37-
export 'profit_table_exception.dart';
38-
export 'reality_check_exception.dart';
39-
export 'residence_exception.dart';
40-
export 'self_exclusion_exception.dart';
41-
export 'server_time_exception.dart';
42-
export 'state_exception.dart';
43-
export 'statement_exception.dart';
44-
export 'tick_exception.dart';
45-
export 'top_up_virtual_exception.dart';
46-
export 'trading_exception.dart';
47-
export 'trading_platform_exception.dart';
48-
export 'transactions_exception.dart';
49-
export 'transfer_exception.dart';
50-
export 'user_exception.dart';
51-
export 'website_status_exception.dart';
2+
export 'base_api_exception.dart';

lib/api/exceptions/exchange_exception.dart

-11
This file was deleted.

lib/api/exceptions/financial_assessment_exception.dart

-11
This file was deleted.

lib/api/exceptions/forget_exception.dart

-11
This file was deleted.

lib/api/exceptions/landing_company_exception.dart

-11
This file was deleted.

lib/api/exceptions/mt5_exception.dart

-10
This file was deleted.

lib/api/exceptions/new_account_exception.dart

-11
This file was deleted.

lib/api/exceptions/p2p_advert_exception.dart

-11
This file was deleted.

0 commit comments

Comments
 (0)