Skip to content

Commit c7c471c

Browse files
authored
Merge pull request #153 from adrienne-deriv/optimise-some-bundles
Code split lodash and lazy load html2canvas
2 parents e46dd93 + c9f3189 commit c7c471c

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

src/components/Modals/NicknameModal/NicknameModal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useEffect } from 'react';
2-
import { debounce } from 'lodash';
2+
import debounce from 'lodash/debounce';
33
import { Controller, useForm } from 'react-hook-form';
44
import { useHistory } from 'react-router-dom';
55
import { BUY_SELL_URL } from '@/constants';

src/components/Modals/NicknameModal/__tests__/NicknameModal.spec.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ const mockedUseAdvertiserCreate = api.advertiser.useCreate as jest.MockedFunctio
1010
const mockPush = jest.fn();
1111
const mockUseAdvertiserInfoState = useAdvertiserInfoState as jest.MockedFunction<typeof useAdvertiserInfoState>;
1212

13-
jest.mock('lodash', () => ({
14-
...jest.requireActual('lodash'),
15-
debounce: jest.fn(f => f),
13+
jest.mock('lodash/debounce', () => ({
14+
...jest.requireActual('lodash/debounce'),
15+
__esModule: true,
16+
default: jest.fn(f => f),
1617
}));
1718

1819
jest.mock('react-router-dom', () => ({

src/components/Modals/ShareAdsModal/ShareAdsModal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { MouseEvent, useEffect, useRef } from 'react';
2-
import html2canvas from 'html2canvas';
32
import { Clipboard } from '@/components';
43
import { ADVERTISER_URL, BUY_SELL, RATE_TYPE } from '@/constants';
54
import { api } from '@/hooks';
@@ -65,6 +64,7 @@ const ShareAdsModal = ({ id, isModalOpen, onRequestClose }: TShareAdsModalProps)
6564
if (divRef.current) {
6665
const p2pLogo = divRef.current.querySelector('.share-ads-card__qr-icon');
6766
if (p2pLogo) {
67+
const { default: html2canvas } = await import('html2canvas');
6868
const canvas = await html2canvas(divRef.current, { allowTaint: true, useCORS: true });
6969
const screenshot = canvas.toDataURL('image/png', 1.0);
7070
const fileName = `${type}_${id}.png`;

src/pages/my-profile/screens/MyProfileAdDetails/MyProfileAdDetails.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useEffect } from 'react';
22
import clsx from 'clsx';
3-
import { debounce } from 'lodash';
3+
import debounce from 'lodash/debounce';
44
import { Control, FieldValues, useForm } from 'react-hook-form';
55
import { FullPageMobileWrapper } from '@/components';
66
import { api } from '@/hooks';

0 commit comments

Comments
 (0)