Skip to content

Commit f738727

Browse files
committed
fix: set initial browser action popup height in Safari
1 parent 21fbee7 commit f738727

2 files changed

Lines changed: 19 additions & 2 deletions

File tree

src/action/App.vue

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,8 +705,11 @@ body {
705705
max-height: 100px;
706706
padding-top: 8px;
707707
padding-bottom: 24px;
708-
transition: max-height 0.3s ease, padding-top 0.3s ease,
709-
padding-bottom 0.3s ease, opacity 0.2s ease;
708+
transition:
709+
max-height 0.3s ease,
710+
padding-top 0.3s ease,
711+
padding-bottom 0.3s ease,
712+
opacity 0.2s ease;
710713
}
711714
712715
.settings-enter-from,
@@ -758,4 +761,12 @@ html.samsung {
758761
height: initial;
759762
}
760763
}
764+
765+
// Safari 17: the popover opens after a delay the first time the action
766+
// button is clicked on macOS 14, unless the height is declared.
767+
@if $target-env == 'safari' {
768+
html {
769+
min-height: 56px;
770+
}
771+
}
761772
</style>

webpack.config.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,12 @@ module.exports = {
127127
sassOptions: {
128128
includePaths: ['node_modules'],
129129
quietDeps: true
130+
},
131+
additionalData: (content, loaderContext) => {
132+
return `
133+
$target-env: "${targetEnv}";
134+
${content}
135+
`;
130136
}
131137
}
132138
}

0 commit comments

Comments
 (0)