Skip to content

Commit a6eb8b7

Browse files
committed
few bug fixes
1 parent 3d5b2f5 commit a6eb8b7

File tree

2 files changed

+27
-31
lines changed

2 files changed

+27
-31
lines changed

popup/popup.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<input type="radio" name="time" value="60" id="time-60"> 1 hour
2626
</div>
2727
</form>
28-
28+
<p id="status"></p>
2929
<script type="text/javascript" src="popup.js"></script>
3030
</body>
3131

popup/popup.js

+26-30
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,31 @@
11
window.onload = () => {
2-
if (localStorage.getItem('time') == null) {
3-
let time = localStorage.getItem('time');
4-
if (time == null) {
5-
localStorage.setItem('time', 15);
6-
document.getElementById('time-15').checked = true;
7-
} else {
8-
let checkedId = 'time-' + time;
9-
document.getElementById(checkedId).checked = true;
10-
}
2+
if (localStorage.getItem('time') !== null) {
3+
let time = localStorage.getItem('time');
4+
if (time == null) {
5+
localStorage.setItem('time', 15);
6+
document.getElementById('time-15').checked = true;
7+
} else {
8+
let checkedId = 'time-' + time;
9+
document.getElementById(checkedId).checked = true;
1110
}
11+
}
1212

13-
var radios = document.forms['time-form'].elements['time'];
14-
for (var i = 0, max = radios.length; i < max; i++) {
15-
radios[i].onclick = function () {
16-
localStorage.setItem('time', this.value);
17-
setTime(Number(this.value));
18-
}
13+
var radios = document.forms['time-form'].elements['time'];
14+
for (var i = 0, max = radios.length; i < max; i++) {
15+
radios[i].onclick = function () {
16+
let time = this.value;
17+
localStorage.setItem('time', time);
18+
document.getElementById('status').innerText = 'Reminder updated to ' + time + ' mins';
19+
setTimeout(() => {
20+
document.getElementById('status').innerText = '';
21+
}, 5000);
22+
setTime(Number(this.value));
1923
}
24+
}
2025

21-
function setTime(time) {
22-
var message = browser.runtime.sendMessage({
23-
'time': time
24-
});
25-
// message.then(handleSuccess, handleError);
26-
}
27-
28-
29-
function handleSuccess(message) {
30-
console.log('Message from the background script:' + message.response);
31-
}
32-
33-
function handleError(error) {
34-
console.log('Error:' + error);
35-
}
26+
function setTime(time) {
27+
browser.runtime.sendMessage({
28+
'time': time
29+
});
30+
}
31+
};

0 commit comments

Comments
 (0)