Skip to content

Devfile registry tests run against removed stacks when test delta is enabled #1753

@michael-valdron

Description

@michael-valdron

Which area is this bug related to?

/area registry

What versions of software are you using?

Go Project

Operating System and version:

Go Pkg Version: 1.24

Bug Summary

Describe the bug: The tests on devfile registry stacks fails when a stack is removed and the TEST_DELTA=true is set.

To Reproduce:

  1. Remove a stack under stacks/
  2. Set TEST_DELTA=true
  3. Run either bash tests/check_odov3.sh or bash tests/check_non_terminating.sh

Expected Behavior

Removed stacks should be ignored from this testing as there is nothing to test.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Output from devfile/registry#627 odo v3 check where EOL dotnet stacks were removed:

 Output from proc 1:
  --- FAIL: TestOdo (0.00s)
      odo_test.go:76: 
          Expected
              <*fs.PathError | 0xc00055e2d0>: 
              stat /home/runner/work/registry/registry/stacks/dotnet50/devfile.yaml: no such file or directory
              {
                  Op: "stat",
                  Path: "/home/runner/work/registry/registry/stacks/dotnet50/devfile.yaml",
                  Err: <syscall.Errno>0x2,
              }
          to be nil
  FAIL

Output from proc 2:
  --- FAIL: TestOdo (0.00s)
      odo_test.go:76: 
          Expected
              <*fs.PathError | 0xc000370a80>: 
              stat /home/runner/work/registry/registry/stacks/dotnet50/devfile.yaml: no such file or directory
              {
                  Op: "stat",
                  Path: "/home/runner/work/registry/registry/stacks/dotnet50/devfile.yaml",
                  Err: <syscall.Errno>0x2,
              }
          to be nil
  FAIL

Additional Context

No response

Any workaround?

Ignore checks during removal of stacks if determined to be caused by the removal and nothing else, since these checks are currently not required.

Suggestion on how to fix the bug

Alter logic under tests/get_stacks.sh to ignore stack changes that completely removes the stack(s) that would produce expected results for this case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/registryDevfile registry for stacks and infrastructurekind/bugSomething isn't working

    Type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions