From adb48f2c64695b0a9a02d9e494c255fe8cc79dcc Mon Sep 17 00:00:00 2001 From: "CORP\\mmrzik" Date: Tue, 16 Jan 2024 12:29:26 +0100 Subject: [PATCH] #183: removed isInstalledVersion() this method was only used once and caused the duplicate msg if the tool was already installed. --- .../tools/ide/tool/LocalToolCommandlet.java | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java index 8505dead7..a5c7a3a7b 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java +++ b/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java @@ -32,7 +32,6 @@ public LocalToolCommandlet(IdeContext context, String tool, Set tags) { super(context, tool, tags); } - /** * @return the {@link Path} where the tool is located (installed). */ @@ -66,7 +65,7 @@ protected boolean doInstall(boolean silent) { // check if we already have this version installed (linked) locally in IDE_HOME/software VersionIdentifier installedVersion = getInstalledVersion(); VersionIdentifier resolvedVersion = installation.resolvedVersion(); - if (isInstalledVersion(resolvedVersion, installedVersion, silent)) { + if (resolvedVersion.equals(installedVersion)) { return false; } // we need to link the version or update the link. @@ -167,19 +166,4 @@ private ToolInstallation createToolInstallation(Path rootDir, VersionIdentifier return new ToolInstallation(rootDir, linkDir, binDir, resolvedVersion); } - private boolean isInstalledVersion(VersionIdentifier expectedVersion, VersionIdentifier installedVersion, - boolean silent) { - - if (expectedVersion.equals(installedVersion)) { - IdeLogLevel level = IdeLogLevel.INFO; - if (silent) { - level = IdeLogLevel.DEBUG; - } - this.context.level(level).log("Version {} of tool {} is already installed", installedVersion, - getToolWithEdition()); - return true; - } - return false; - } - }