Skip to content

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented Dec 2, 2025

This PR fixes #1633

Implemented changes:

  • change ToolCommandlet.cveCheck to ignore unstable versions for suggestions if the requested version was stable
  • added VersionIdentifier.isStable()
  • changed VersionSegment to be unstable for *!
  • extended JUnit

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille added this to the release:2025.12.001 milestone Dec 2, 2025
@hohwille hohwille self-assigned this Dec 2, 2025
@hohwille hohwille added security CVEs or other vulnerabilities install installation process of IDE + tools and install commandlet bugfix PR that fixes a bug issue labels Dec 2, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Dec 2, 2025
@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Dec 2, 2025
@hohwille hohwille merged commit 2f9b0f4 into devonfw:main Dec 2, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Team Review to ✅ Done in IDEasy board Dec 2, 2025
@hohwille hohwille deleted the feature/1633-cve-suggest-stable-versions branch December 2, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue install installation process of IDE + tools and install commandlet security CVEs or other vulnerabilities

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

CVE suggestions show unstable versions

1 participant