From 603deda7391ea1fb61c18b42fa79e55fb86390cf Mon Sep 17 00:00:00 2001
From: Marco Vomiero <colocomarco1@gmail.com>
Date: Thu, 20 Jun 2024 13:43:32 +0200
Subject: [PATCH 1/4] bugfix

---
 .../devonfw/tools/ide/context/AbstractIdeContext.java | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
index 0902ecfc8..1bc508c57 100644
--- a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
+++ b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
@@ -200,7 +200,7 @@ public AbstractIdeContext(IdeLogLevel minLogLevel, Function<IdeLogLevel, IdeSubL
       }
     }
     if (ideRootPath == null || !Files.isDirectory(ideRootPath)) {
-      error("IDE_ROOT is not set or not a valid directory.");
+      error("You are not inside an IDEasy installation: " + System.getProperty("user.dir"));
     }
     this.ideRoot = ideRootPath;
 
@@ -874,10 +874,10 @@ public int run(CliArguments arguments) {
   }
 
   /**
-   * @param cmd the potential {@link Commandlet} to
-   *     {@link #apply(CliArguments, Commandlet, CompletionCandidateCollector) apply} and {@link Commandlet#run() run}.
-   * @return {@code true} if the given {@link Commandlet} matched and did {@link Commandlet#run() run} successfully,
-   *     {@code false} otherwise (the {@link Commandlet} did not match and we have to try a different candidate).
+   * @param cmd the potential {@link Commandlet} to {@link #apply(CliArguments, Commandlet, CompletionCandidateCollector) apply} and
+   * {@link Commandlet#run() run}.
+   * @return {@code true} if the given {@link Commandlet} matched and did {@link Commandlet#run() run} successfully, {@code false} otherwise (the
+   * {@link Commandlet} did not match and we have to try a different candidate).
    */
   private boolean applyAndRun(CliArguments arguments, Commandlet cmd) {
 
@@ -1042,6 +1042,7 @@ private String findBashOnWindows() {
 
   @Override
   public WindowsPathSyntax getPathSyntax() {
+
     return this.pathSyntax;
   }
 

From 4b6238d934f335258285276fad74237864357dff Mon Sep 17 00:00:00 2001
From: Marco Vomiero <colocomarco1@gmail.com>
Date: Thu, 20 Jun 2024 15:56:14 +0200
Subject: [PATCH 2/4] remove log idehomenotfound

---
 .../com/devonfw/tools/ide/context/AbstractIdeContext.java     | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
index 1bc508c57..df943c30c 100644
--- a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
+++ b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
@@ -180,9 +180,7 @@ public AbstractIdeContext(IdeLogLevel minLogLevel, Function<IdeLogLevel, IdeSubL
     // detection completed, initializing variables
     setCwd(userDir, workspace, currentDir);
     Path ideRootPath = null;
-    if (currentDir == null) {
-      info(getMessageIdeHomeNotFound());
-    } else {
+    if (currentDir != null) {
       debug(getMessageIdeHomeFound());
       ideRootPath = this.ideHome.getParent();
     }

From 791c321b292e8cbb6097133e02364ac577a49eb1 Mon Sep 17 00:00:00 2001
From: Marco Vomiero <colocomarco1@gmail.com>
Date: Thu, 27 Jun 2024 12:24:07 +0200
Subject: [PATCH 3/4] reformat code

---
 .../com/devonfw/tools/ide/context/AbstractIdeContext.java  | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
index bad1a5848..7ab2eba21 100644
--- a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
+++ b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
@@ -197,9 +197,10 @@ public AbstractIdeContext(IdeLogLevel minLogLevel, Function<IdeLogLevel, IdeSubL
         }
       }
     }
-    if (ideRootPath == null || !Files.isDirectory(ideRootPath)) {
-      error("You are not inside an IDEasy installation: " + System.getProperty("user.dir"));
+    if (ideRootPath == null || !Files.isDirectory(ideRootPath) || currentDir != null) {
+      error(getMessageIdeHomeNotFound());
     }
+    
     this.ideRoot = ideRootPath;
 
     setCwd(userDir, workspace, currentDir);
@@ -278,7 +279,7 @@ private String getMessageIdeHomeFound() {
 
   private String getMessageIdeHomeNotFound() {
 
-    return "You are not inside an IDE installation: " + this.cwd;
+    return "You are not inside an IDE installation: " + System.getProperty("user.dir");
   }
 
   /**

From 8121fe7dd83ba0a93e0c2ee0f17e3ff12bc25df6 Mon Sep 17 00:00:00 2001
From: Marco Vomiero <colocomarco1@gmail.com>
Date: Thu, 27 Jun 2024 12:27:40 +0200
Subject: [PATCH 4/4] reformat code

---
 .../java/com/devonfw/tools/ide/context/AbstractIdeContext.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
index 7ab2eba21..5cf2eb58f 100644
--- a/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
+++ b/cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
@@ -200,7 +200,7 @@ public AbstractIdeContext(IdeLogLevel minLogLevel, Function<IdeLogLevel, IdeSubL
     if (ideRootPath == null || !Files.isDirectory(ideRootPath) || currentDir != null) {
       error(getMessageIdeHomeNotFound());
     }
-    
+
     this.ideRoot = ideRootPath;
 
     setCwd(userDir, workspace, currentDir);