Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Readychecker doesn't work when some services are out of the Kubernetes cluster #111

Closed
raoufkh opened this issue Jan 2, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@raoufkh
Copy link
Contributor

raoufkh commented Jan 2, 2025

Is your feature request related to a problem?

Hello! First of all, I'd like to thank you for maintaining this project.

That said, the current version expects dependencies (elasticsearch, redis, ...) are deployed via the OpenCTI Helm chart for the ready checker to work well, as it makes use of addresses that would be set if the dependecies have been deployed as subcharts of the OpenCTI chart.

Will you be okay with that contribution?

Thank you in advance,
Raouf

Describe the solution you'd like

I propose to modify to the values and Platform deployment manifest to add the possibility of checking services that are deployed in other ways (for example in case of using Cloud-based managed services).

I plan to add a field called address in the items of the services list:
services:

  • name: elasticsearch
    address: elasticsearchip
    port: 9200
  • name: minio
    port: 9000
  • name: rabbitmq
    port: 5672
  • name: redis-master
    port: 6379

The URL to use for checking for readiness wille be **address** if this field is specified, otherwise chart-fullname-**name** .

Describe alternatives you've considered

I think the proposed solution is good as it is simple and it doesn't make significant changes to the values.

Additional context

Would you be okay with such a contribution? With your agreement I will try to make it available ASAP.

@raoufkh raoufkh added the enhancement New feature or request label Jan 2, 2025
@raoufkh raoufkh changed the title [repo] Readychecker when some services are out of the Kubernetes cluster [repo] Readychecker doesn' work when some services are out of the Kubernetes cluster Jan 2, 2025
@raoufkh raoufkh changed the title [repo] Readychecker doesn' work when some services are out of the Kubernetes cluster [repo] Readychecker doesn't work when some services are out of the Kubernetes cluster Jan 2, 2025
@ialejandro
Copy link
Member

Thx! Go ahead ❤️

@raoufkh
Copy link
Contributor Author

raoufkh commented Jan 6, 2025

Done #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants