Skip to content

Commit 247ef1c

Browse files
committed
refactor(zone.js): ensure compatibility with noImplicitOverride
Adds the `override` keyword to the `zone.js` sources to ensure compatibility with `noImplicitOverride`.
1 parent 91c1bb6 commit 247ef1c

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

packages/zone.js/test/common/Error.spec.ts

+10-10
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@ class BaseError extends Error {
1919
this._nativeError = nativeError;
2020
}
2121

22-
get message() {
22+
override get message() {
2323
return this._nativeError.message;
2424
}
25-
set message(message) {
25+
override set message(message) {
2626
this._nativeError.message = message;
2727
}
28-
get name() {
28+
override get name() {
2929
return this._nativeError.name;
3030
}
31-
get stack() {
31+
override get stack() {
3232
return (this._nativeError as any).stack;
3333
}
34-
set stack(value) {
34+
override set stack(value) {
3535
(this._nativeError as any).stack = value;
3636
}
37-
toString() {
37+
override toString() {
3838
return this._nativeError.toString();
3939
}
4040
}
@@ -47,7 +47,7 @@ class WrappedError extends BaseError {
4747
this.originalError = error;
4848
}
4949

50-
get stack() {
50+
override get stack() {
5151
return ((this.originalError instanceof Error ? this.originalError : this._nativeError) as any)
5252
.stack;
5353
}
@@ -58,7 +58,7 @@ class TestError extends WrappedError {
5858
super(`${message} caused by: ${error instanceof Error ? error.message : error}`, error);
5959
}
6060

61-
get message() {
61+
override get message() {
6262
return 'test ' + this.originalError.message;
6363
}
6464
}
@@ -68,11 +68,11 @@ class TestMessageError extends WrappedError {
6868
super(`${message} caused by: ${error instanceof Error ? error.message : error}`, error);
6969
}
7070

71-
get message() {
71+
override get message() {
7272
return 'test ' + this.originalError.message;
7373
}
7474

75-
set message(value) {
75+
override set message(value) {
7676
this.originalError.message = value;
7777
}
7878
}

packages/zone.js/test/common/Promise.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ describe(
122122
super(fn);
123123
}
124124

125-
static get[Symbol.species]() {
125+
static override get[Symbol.species]() {
126126
return MyPromise;
127127
}
128128
}

packages/zone.js/test/common/util.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ describe('utils', function() {
9191
}
9292
}
9393
class ChildType extends Type {
94-
method(..._args: any[]) {
94+
override method(..._args: any[]) {
9595
childArgs = _args;
9696
childSelf = this;
9797
return 'ChildOK';

0 commit comments

Comments
 (0)