-
Notifications
You must be signed in to change notification settings - Fork 12
chore: add NNS proposal to upgrade bitcoin canister #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ninegua
wants to merge
1
commit into
master
Choose a base branch
from
paulliu/nns-proposal-release-2025-12-03
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Proposal to upgrade the Bitcoin canister | ||
|
|
||
| Repository: `https://github.com/dfinity/bitcoin-canister.git` | ||
|
|
||
| Git hash: `8d512125e772d31e2bb8692e0473fa48dc13d19e` | ||
|
|
||
| New compressed Wasm hash: `ee669a352fbca79f21aa6d0b7190f4daae74ef203b0ccf8d7fb82123dfd2d6a6` | ||
|
|
||
| Upgrade args hash: `0fee102bd16b053022b69f2c65fd5e2f41d150ce9c214ac8731cfaf496ebda4e` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. verified 🎉 |
||
|
|
||
| Target canister: `ghsi2-tqaaa-aaaan-aaaca-cai` | ||
|
|
||
| Previous Bitcoin canister proposal: https://dashboard.internetcomputer.org/proposal/138813 | ||
|
|
||
| --- | ||
|
|
||
| ## Motivation | ||
|
|
||
| Regular upgrade of the Bitcoin canister to the latest [release/2025-12-03](https://github.com/dfinity/bitcoin-canister/releases/tag/release%2F2025-12-03). | ||
|
|
||
| ## Release Notes | ||
|
|
||
| ``` | ||
| git log --format='%C(auto) %h %s' 46e1a4cb276349aec9b31e400f88712502f5ad9a..8d512125e772d31e2bb8692e0473fa48dc13d19e -- canister interface types | ||
| 8d51212 fix: Remove custom PartialOrd implementation for Utxo type (#451) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. understanding question: will you also do a new release of https://crates.io/crates/ic-btc-interface ? |
||
| 13c6ff2 ci: add canister endpoint checks (#447) | ||
| 91b1c67 chore: bump `ic-cdk` to v0.19.0 (#446) | ||
| 7f84397 fix: add `burn_cycles` field to `SetConfigRequest` (#444) | ||
| 02af290 refactor: avoid panic in block tree deserialization (#438) | ||
| f202301 refactor: generic support for BlockTree serialization (#434) | ||
| 095a2b4 refactor: make BlockTree generic (#432) | ||
| e413147 refactor: use fixed size array for BlockHash type (#433) | ||
| af000cc refactor: replace RefCell<Option<T>> with OnceCell<T> (#431) | ||
| b506535 chore: upgrade ic-cdk and other dependency versions (#429) | ||
| bd965ea chore(ic-btc-interface): release v0.2.3 (#426) | ||
| ``` | ||
|
|
||
| ## Upgrade args | ||
|
|
||
| ``` | ||
| git fetch | ||
| git checkout 8d512125e772d31e2bb8692e0473fa48dc13d19e | ||
| didc encode '()' | xxd -r -p | sha256sum | ||
| ``` | ||
|
|
||
| ## Wasm Verification | ||
|
|
||
| Verify that the hash of the gzipped WASM matches the proposed hash. | ||
| NOTE: This process is not yet guaranteed to match on Apple Silicon. | ||
|
|
||
| ``` | ||
| git fetch | ||
| git checkout 8d512125e772d31e2bb8692e0473fa48dc13d19e | ||
| docker build -t canisters . | ||
| docker run --rm canisters cat /ic-btc-canister.wasm.gz > ic-btc-canister.wasm.gz | ||
| sha256sum ic-btc-canister.wasm.gz | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed 🎉