Skip to content

Commit 27fa082

Browse files
authored
Merge pull request #1068 from dfinity/paulliu/drop-host-header
fix: drop Host header in https outcall request
2 parents 34ec579 + 674a6e9 commit 27fa082

File tree

3 files changed

+1
-10
lines changed
  • motoko/send_http_post/src/send_http_post_backend
  • rust
    • send_http_get/src/send_http_get_backend/src
    • send_http_post/src/send_http_post_backend/src

3 files changed

+1
-10
lines changed

motoko/send_http_post/src/send_http_post_backend/main.mo

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ actor {
3131
//idempotency keys should be unique so we create a function that generates them.
3232
let idempotency_key : Text = generateUUID();
3333
let request_headers = [
34-
{ name = "Host"; value = host # ":443" },
3534
{ name = "User-Agent"; value = "http_post_sample" },
3635
{ name = "Content-Type"; value = "application/json" },
3736
{ name = "Idempotency-Key"; value = idempotency_key },

rust/send_http_get/src/send_http_get_backend/src/lib.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ async fn get_icp_usd_exchange() -> String {
3737
// 2.2 prepare headers for the system http_request call
3838
//Note that `HttpHeader` is declared in line 4
3939
let request_headers = vec![
40-
HttpHeader {
41-
name: "Host".to_string(),
42-
value: format!("{host}:443"),
43-
},
4440
HttpHeader {
4541
name: "User-Agent".to_string(),
4642
value: "exchange_rate_canister".to_string(),

rust/send_http_post/src/send_http_post_backend/src/lib.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ async fn send_http_post_request() -> String {
2828
// 2.2 prepare headers for the system http_request call
2929
//Note that `HttpHeader` is declared in line 4
3030
let request_headers = vec![
31-
HttpHeader {
32-
name: "Host".to_string(),
33-
value: format!("{host}:443"),
34-
},
3531
HttpHeader {
3632
name: "User-Agent".to_string(),
3733
value: "demo_HTTP_POST_canister".to_string(),
@@ -191,4 +187,4 @@ fn transform(raw: TransformArgs) -> HttpResponse {
191187
ic_cdk::api::print(format!("Received an error from coinbase: err = {:?}", raw));
192188
}
193189
res
194-
}
190+
}

0 commit comments

Comments
 (0)