feat(ICRC-Rosetta): add ICRC-107 fee collector block handling #7697
+619
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciej-rosetta-feecol
maciejdfinity
changed the title
maciejdfinity
commented
Dec 9, 2025
| "#, | ||
| [], | ||
| )?; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
With the metadata table, updating ckBTC balances take ~4m. This is similar to having an index on operation_type and searching for the fee collector in the blocks table and having a separate table for fee collectors.
maciejdfinity
commented
Dec 9, 2025
| fee_collector: _, | ||
| caller: _, | ||
| } => ( | ||
| "107feecol", |
Contributor
Author
There was a problem hiding this comment.
I think this constant should be defined in the icrc-ledger-types but it's not used there yet. I added a note to DEFI-1901 to create the constant when we implement the 107 schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fee collector block handling according to the ICRC-107 standard (https://github.com/dfinity/ICRC/blob/main/ICRCs/ICRC-107/ICRC-107.md). The fee collector information is stored in a separate table (
fee_collectors_107).