feat(PocketIC): support for testing bounded-wait calls #7936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR facilitates testing bounded-wait calls by allowing the test author to specify the first and last subnet executed in a round. This way, it is possible to make the caller receive a timeout while the callee processes the message before or after the deadline.
Technically, this is achieved by extending the configuration of the "tick" endpoint of the PocketIC server (executing a round). In addition, the configuration types are now simplified and decoupled between the server and client (user-facing library). While the simplification and decoupling is technically a breaking change, we expect its impact to be limited since the current configuration options (configuring subnet blockmakers) are only expected to be used internally.