feat(canister_logging): add log_memory_store to system_state #7939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymar
commented
Dec 4, 2025
| // 8 | 0 | N/A | canister_states/00000000000000c80101/vmemory_0.bin | ||
| // 9 | 0 | N/A | canister_states/00000000000000c80101/wasm_chunk_store.bin | ||
| // 10 | 97 | 4 | system_metadata.pbuf | ||
| // 0 | 0 | 0 | canister_states/00000000000000640101/log_memory_store.overlay |
Contributor
There was a problem hiding this comment.
I think they are the wrong way around, as they are meant to be sorted. So canister.pbuf should be 0, and log_memory_store should be 1. But either way software.wasm is gonna be 2, so the actual code change makes sense.
Contributor
Author
There was a problem hiding this comment.
yes, they are sorted, but log memory store files have some prefixes with zeros:
file_idx | file_size | chunk_idx | path
0 | 4132 | 0 | "canister_states/00000000000000640101/0000000000000001_0000_log_memory_store.overlay"
1 | 342 | 1 | "canister_states/00000000000000640101/canister.pbuf"
2 | 18 | 2 | "canister_states/00000000000000640101/software.wasm"
3 | 4132 | 3 | "canister_states/00000000000000c80101/0000000000000001_0000_log_memory_store.overlay"
4 | 342 | 4 | "canister_states/00000000000000c80101/canister.pbuf"
5 | 18 | 5 | "canister_states/00000000000000c80101/software.wasm"
6 | 98 | 6 | "system_metadata.pbuf"
maksymar
commented
Dec 5, 2025
|
|
||
| env.tick(); | ||
| assert_eq!(page_maps_by_status("loaded", &env), 0); | ||
| assert_eq!(page_maps_by_status("loaded", &env), 1); |
Contributor
Author
There was a problem hiding this comment.
FYI: This is probably due to the fact that log memory store initializes the 1 page header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.