refactor(crypto): remove CSP layer for basic-sig signing #7966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the crypto component so that the creation of basic (=Ed25519) signatures is done by directly calling the vault, rather than doing the obsolete indirection via the crypto service provider (CSP) layer.
With this PR, basic signature signature creation also no longer calculates a (private) key ID from the signing node's node signing public key stored in the registry, and thus also no longer reads this public key from the registry.
Also removes the old set of basic-signature unit tests and creates a fresh set of respective integration tests.
This also makes the
BasicSignerssigner: NodeIdandregistry_version: RegistryVersionparameters obsolete/unused, which will be removed in a follow-up PR.The respective code for basic-signing in the CSP is kept for now, because it is still used in various tests for basic-sig verification in the CSP, and can/will be removed once we also go directly to the vault for basic-sig verification.