Skip to content

Conversation

@matthewhammer
Copy link
Contributor

@matthewhammer matthewhammer commented Jun 15, 2022

As per the discussion with @crusso and @rossberg, Array to buffer should be Buffer.fromArray, not Array.buffer, as was just merged.

Related:

@matthewhammer
Copy link
Contributor Author

@crusso PTAL

@matthewhammer matthewhammer enabled auto-merge (squash) June 16, 2022 03:19
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, one more iteration - I mistakenly thought the existing toVarArray was called toArrayMut. We are inconsistent in the libs.... but I guess should at least be consistent within the one file.

matthewhammer and others added 2 commits June 17, 2022 08:44
Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>
@matthewhammer
Copy link
Contributor Author

matthewhammer commented Jun 17, 2022

We are inconsistent in the libs.

Created #391

@matthewhammer matthewhammer merged commit 7ca5b2c into master Jun 17, 2022
@matthewhammer matthewhammer deleted the array-to-buffer branch June 17, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants