Correctly collapse long outputs

Adds tests for very long outputs

.github/workflows/test-apply.yaml

@@ -1173,3 +1173,22 @@ jobs:
         uses: ./terraform-apply
         with:
           path: tests/workflows/test-apply/long_outputs
+
+  outputs:
+    runs-on: ubuntu-latest
+    name: Apply a plan with outputs
+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Plan
+        uses: ./terraform-plan
+        with:
+          path: tests/workflows/test-apply/outputs
+
+      - name: Apply
+        uses: ./terraform-apply
+        with:
+          path: tests/workflows/test-apply/outputs

image/src/github_pr_comment/__main__.py

@@ -411,13 +411,13 @@ def format_plan_text(plan_text: str) -> Tuple[str, str]:
 
 def format_output_status(outputs: Optional[dict], remaining_size: int) -> str:
     status = f':white_check_mark: Plan applied in {job_markdown_ref()}'
-    if outputs is not None:
-        stripped_output = render_outputs(outputs).strip()
+    stripped_output = render_outputs(outputs).strip()
 
+    if stripped_output:
         if len(stripped_output) > remaining_size:
             stripped_output = truncate(stripped_output, remaining_size, 'Outputs are too large to fit in a PR comment. See the full outputs in the workflow log.')
 
-        open_att = ' open' if len(stripped_output.splitlines()) > 6 else ''
+        open_att = ' open' if len(stripped_output.splitlines()) < 6 else ''
 
         status += f'''\n<details{open_att}><summary>Outputs</summary>
 

tests/workflows/test-apply/long_outputs/main.tf

@@ -1,8 +1,8 @@
 variable "input" {
     type = string
-    default = "This is my long string\n"
+    default = "This is my long string"
 }
 
 output "output" {
-  value = repeat(var.input, 5000)
+  value = join('\n', [for i in range(0, 5000): var.input])
 }

tests/workflows/test-apply/outputs/main.tf

@@ -0,0 +1,26 @@
+output "sensitive" {
+  value = "This is a sensistive value"
+  sensitive = true
+}
+
+output "not_sensitive" {
+  value = "This is not a sensistive value"
+}
+
+output "sensitive_map" {
+  value = {
+    "password" = "passw0rd"
+  }
+  sensitive = true
+}
+
+output "not_sensitive_complex" {
+  value = [
+    {
+      "hello" = "world"
+    },
+    {
+      "hello" = "again"
+    }
+  ]
+}