Merge pull request #7657 from diffblue/20230411-remove-ubuntu-1804

TGWDB · web-flow · commit 00f1d72b131a · 2023-04-12T09:53:08.000+01:00
Remove Ubuntu-18.04 jobs since github deprecated them
diff --git a/.github/workflows/README.md b/.github/workflows/README.md
@@ -38,7 +38,6 @@ do that for:
 
 * a `docker` image
 * an `ubuntu-20.04` package
-* an `ubuntu-18.04` package
 * a `windows-msi` installer package
 
 Last but not least, we are also performing a coverage statistics collection
diff --git a/.github/workflows/pull-request-checks.yaml b/.github/workflows/pull-request-checks.yaml
@@ -780,71 +780,6 @@ jobs:
           echo "msi_installer=build/$msi_name" >> $env:GITHUB_OUTPUT
           echo "msi_name=$msi_name" >> $env:GITHUB_OUTPUT
 
-  # This job takes approximately 25 to 43 minutes
-  ubuntu-18_04-package:
-    runs-on: ubuntu-18.04
-    env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          submodules: recursive
-      - name: Fetch dependencies
-        run: |
-          sudo apt-get update
-          sudo apt-get install --no-install-recommends -y g++ gdb flex bison cmake ninja-build maven jq libxml2-utils dpkg-dev ccache
-          # remove libgcc-s1, which isn't normally available in Ubuntu 18.04
-          target=$(dpkg-query -W --showformat='${Version}\n' gcc-8-base | head -n 1)
-          # libgcc1 uses an epoch, thus the extra 1:
-          sudo apt-get install -y --allow-downgrades --reinstall gcc g++ libgcc-s1- libstdc++6=$target liblsan0=$target libtsan0=$target libcc1-0=$target libgcc1=1:$target gdb=8.1.1-0ubuntu1
-      - name: Download z3 4.11.0 from the python wheel package, extract it and make sure it can be deployed
-        run: |
-          sudo apt-get install --no-install-recommends -y unzip
-          # download the z3 python wheel package
-          wget -O z3.4.11.0.whl https://github.com/Z3Prover/z3/releases/download/z3-4.11.0/z3_solver-4.11.0.0-py2.py3-none-manylinux1_x86_64.whl
-          # unpack the bundle using python
-          unzip z3.4.11.0.whl
-          # make z3 executable and move it in /usr/local/bin
-          chmod u+x ./z3_solver-4.11.0.0.data/data/bin/z3
-          mv ./z3_solver-4.11.0.0.data/data/bin/z3 /usr/local/bin/
-          z3 --version
-      - name: Download cvc-5 from the releases page and make sure it can be deployed
-        run: |
-          wget -O cvc5 https://github.com/cvc5/cvc5/releases/download/cvc5-${{env.cvc5-version}}/cvc5-Linux
-          chmod u+x cvc5
-          mv cvc5 /usr/local/bin
-          cvc5 --version
-      - name: Prepare ccache
-        uses: actions/cache@v3
-        with:
-          path: .ccache
-          key: ${{ runner.os }}-18.04-Release-${{ github.ref }}-${{ github.sha }}-PR
-          restore-keys: |
-            ${{ runner.os }}-18.04-Release-${{ github.ref }}
-            ${{ runner.os }}-18.04-Release
-      - name: ccache environment
-        run: |
-          echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
-          echo "CCACHE_DIR=$PWD/.ccache" >> $GITHUB_ENV
-      - name: Zero ccache stats and limit in size
-        run: ccache -z --max-size=500M
-      - name: Configure CMake
-        run: cmake -S . -Bbuild -G Ninja -DCMAKE_BUILD_TYPE=Release -Dsat_impl=cadical
-      - name: Build using Ninja
-        run: ninja -C build -j2
-      - name: Print ccache stats
-        run: ccache -s
-      - name: Run CTest
-        run: cd build; ctest . -V -L CORE -C Release -j2
-      - name: Create packages
-        id: create_packages
-        run: |
-          cd build
-          ninja package
-          deb_package_name="$(ls *.deb)"
-          echo "deb_package=./build/$deb_package_name" >> $GITHUB_OUTPUT
-          echo "deb_package_name=ubuntu-18.04-$deb_package_name" >> $GITHUB_OUTPUT
-
   # This job takes approximately 2 to 3 minutes
   check-string-table:
     runs-on: ubuntu-20.04
diff --git a/.github/workflows/regular-release.yaml b/.github/workflows/regular-release.yaml
@@ -56,11 +56,9 @@ jobs:
 
             ## Ubuntu
 
-            On Ubuntu, install CBMC by downloading the *.deb package below for your version of Ubuntu and install with one of
+            On Ubuntu, install CBMC by downloading the *.deb package below for your version of Ubuntu and install with
 
             ```sh
-            # Ubuntu 18:
-            $ dpkg -i ubuntu-18.04-cbmc-${{ env.CBMC_VERSION }}-Linux.deb
             # Ubuntu 20:
             $ dpkg -i ubuntu-20.04-cbmc-${{ env.CBMC_VERSION }}-Linux.deb
             ```
diff --git a/.github/workflows/release-packages.yaml b/.github/workflows/release-packages.yaml
@@ -149,93 +149,6 @@ jobs:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
           SLACK_MESSAGE: "${{ job.status == 'success' && 'Ubuntu 20.04 package built and uploaded successfully' || 'Ubuntu 20.04 package build failed' }}"
 
-  ubuntu-18_04-package:
-    runs-on: ubuntu-18.04
-    env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          submodules: recursive
-      - name: Fetch dependencies
-        run: |
-          sudo apt-get update
-          sudo apt-get install --no-install-recommends -y g++ gdb flex bison cmake ninja-build maven jq libxml2-utils dpkg-dev ccache
-          # remove libgcc-s1, which isn't normally available in Ubuntu 18.04
-          target=$(dpkg-query -W --showformat='${Version}\n' gcc-8-base | head -n 1)
-          # libgcc1 uses an epoch, thus the extra 1:
-          sudo apt-get install -y --allow-downgrades --reinstall gcc g++ libgcc-s1- libstdc++6=$target liblsan0=$target libtsan0=$target libcc1-0=$target libgcc1=1:$target gdb=8.1.1-0ubuntu1
-      - name: Download z3 4.11.0 from the python wheel package, extract it and make sure it can be deployed
-        run: |
-          sudo apt-get install --no-install-recommends -y unzip
-          # download the z3 python wheel package
-          wget -O z3.4.11.0.whl https://github.com/Z3Prover/z3/releases/download/z3-4.11.0/z3_solver-4.11.0.0-py2.py3-none-manylinux1_x86_64.whl
-          # unpack the bundle using python
-          unzip z3.4.11.0.whl
-          # make z3 executable and move it in /usr/local/bin
-          chmod u+x ./z3_solver-4.11.0.0.data/data/bin/z3
-          mv ./z3_solver-4.11.0.0.data/data/bin/z3 /usr/local/bin/
-          z3 --version
-      - name: Download cvc-5 from the releases page and make sure it can be deployed
-        run: |
-          wget -O cvc5 https://github.com/cvc5/cvc5/releases/download/cvc5-${{env.cvc5-version}}/cvc5-Linux
-          chmod u+x cvc5
-          mv cvc5 /usr/local/bin
-          cvc5 --version
-      - name: Prepare ccache
-        uses: actions/cache@v3
-        with:
-          path: .ccache
-          key: ${{ runner.os }}-18.04-Release-${{ github.ref }}-${{ github.sha }}-RELEASEPKG
-          restore-keys: |
-            ${{ runner.os }}-18.04-Release-${{ github.ref }}
-            ${{ runner.os }}-18.04-Release
-      - name: ccache environment
-        run: |
-          echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
-          echo "CCACHE_DIR=$PWD/.ccache" >> $GITHUB_ENV
-      - name: Configure CMake
-        run: |
-          mkdir build
-          cd build
-          cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -Dsat_impl="minisat2;cadical"
-      - name: Zero ccache stats and limit in size
-        run: ccache -z --max-size=500M
-      - name: Build using Ninja
-        run: ninja -C build -j2
-      - name: Print ccache stats
-        run: ccache -s
-      - name: Run CTest
-        run: cd build; ctest . -V -L CORE -C Release -j2
-      - name: Create packages
-        id: create_packages
-        run: |
-          cd build
-          ninja package
-          deb_package_name="$(ls *.deb)"
-          echo "deb_package=./build/$deb_package_name" >> $GITHUB_OUTPUT
-          echo "deb_package_name=ubuntu-18.04-$deb_package_name" >> $GITHUB_OUTPUT
-      - name: Get release info
-        id: get_release_info
-        uses: bruceadams/get-release@v1.3.2
-      - name: Upload binary packages
-        uses: actions/upload-release-asset@v1
-        with:
-          upload_url: ${{ steps.get_release_info.outputs.upload_url }}
-          asset_path: ${{ steps.create_packages.outputs.deb_package }}
-          asset_name: ${{ steps.create_packages.outputs.deb_package_name }}
-          asset_content_type: application/x-deb
-      - name: Slack notification of CI status
-        uses: rtCamp/action-slack-notify@v2
-        if: success() || failure()
-        env:
-          SLACK_CHANNEL: team_open_source
-          SLACK_COLOR: ${{ job.status }}
-          SLACK_USERNAME: Github Actions CI bot
-          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
-          SLACK_MESSAGE: "${{ job.status == 'success' && 'Ubuntu 18.04 package built and uploaded successfully' || 'Ubuntu 18.04 package build failed' }}"
-
-
   homebrew-pr:
     runs-on: macos-11
     steps:
