Skip to content

Commit 1e8a703

Browse files
authored
Merge pull request #7798 from tautschnig/cleanup/cleaning
Add missing cleanup
2 parents bcf6f4f + da99314 commit 1e8a703

File tree

22 files changed

+247
-11
lines changed

22 files changed

+247
-11
lines changed

.github/workflows/pull-request-checks.yaml

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,24 @@ jobs:
6969
make TAGS="[!shouldfail]" -C jbmc/unit test IPASIR=$PWD/riss.git/riss
7070
- name: Run regression tests
7171
run: |
72-
make -C regression test-parallel JOBS=2
72+
make -C regression test-parallel JOBS=2 LIBS="$PWD/riss.git/release/lib/libriss-coprocessor.a -lpthread" IPASIR=$PWD/riss.git/riss
7373
make -C regression/cbmc test-paths-lifo
7474
env PATH=$PATH:`pwd`/src/solvers make -C regression/cbmc test-cprover-smt2
7575
make -C jbmc/regression test-parallel JOBS=2
76+
- name: Check cleanup
77+
run: |
78+
make -C src clean IPASIR=$PWD/riss.git/riss
79+
make -C jbmc/src clean IPASIR=$PWD/riss.git/riss
80+
rm -r riss.git
81+
rm src/goto-cc/goto-ld
82+
make -C unit clean
83+
make -C regression clean
84+
make -C jbmc/unit clean
85+
make -C jbmc/regression clean
86+
if [[ $(git status --ignored --porcelain | grep -v .ccache/) ]] ; then
87+
git status --ignored
88+
exit 1
89+
fi
7690
7791
# This job takes approximately 25 to 34 minutes
7892
check-ubuntu-20_04-make-clang:
@@ -241,6 +255,17 @@ jobs:
241255
ls *.deb
242256
- name: Run tests
243257
run: cd build; ctest . -V -L CORE -j2
258+
- name: Check cleanup
259+
run: |
260+
rm -r build
261+
rm scripts/bash-autocomplete/cbmc.sh
262+
make -C unit clean
263+
make -C regression clean
264+
make -C jbmc/regression clean
265+
if [[ $(git status --ignored --porcelain | grep -v .ccache/) ]] ; then
266+
git status --ignored
267+
exit 1
268+
fi
244269
245270
# This job takes approximately 34 to 38 minutes
246271
check-ubuntu-22_04-make-clang:

regression/Makefile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ DIRS = cbmc-shadow-memory \
3030
goto-diff \
3131
test-script \
3232
goto-analyzer-taint \
33+
goto-bmc/goto-bmc-symex-ready-goto \
34+
goto-bmc/goto-bmc-non-symex-ready-goto \
35+
goto-bmc \
3336
goto-gcc \
3437
goto-cl \
3538
goto-cc-cbmc \
@@ -59,6 +62,7 @@ DIRS = cbmc-shadow-memory \
5962
cbmc-sequentialization \
6063
cpp-linter \
6164
catch-framework \
65+
libcprover-cpp \
6266
# Empty last line
6367

6468
ifeq ($(OS),Windows_NT)
@@ -110,9 +114,7 @@ test-parallel:
110114

111115
.PHONY: clean
112116
clean:
113-
@for dir in *; do \
114-
if [ -d "$$dir" ]; then \
115-
$(MAKE) -C "$$dir" clean; \
116-
fi; \
117+
@for dir in $(DIRS); do \
118+
$(MAKE) -C "$$dir" clean; \
117119
done;
118120
$(RM) tests.log

regression/ansi-c/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,4 @@ build_goto_binaries:
6464
clean:
6565
find . -name '*.out' -execdir $(RM) '{}' \;
6666
find . -name '*.gb' -execdir $(RM) '{}' \;
67-
$(RM) tests.log tests-c++-front-end.log
67+
$(RM) tests*.log

regression/catch-framework/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ test:
66
tests.log: ../test.pl test
77

88
clean:
9+
find . -name '*.out' -execdir $(RM) '{}' \;
910
$(RM) tests*.log

regression/cbmc-primitives/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ tests.log: ../test.pl
1111

1212
clean:
1313
find . -name '*.out' -execdir $(RM) '{}' \;
14-
$(RM) tests.log
14+
$(RM) tests*.log

regression/cbmc/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,5 @@ tests.log: ../test.pl test
3939
clean:
4040
find . -name '*.out' -execdir $(RM) '{}' \;
4141
find . -name '*.smt2' -execdir $(RM) '{}' \;
42+
$(RM) export-symex-ready-goto/exported.symex.ready.goto
4243
$(RM) tests*.log

regression/contracts-dfcc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ tests.log: ../test.pl test
3434

3535
clean:
3636
@for dir in *; do \
37-
$(RM) tests.log; \
3837
if [ -d "$$dir" ]; then \
3938
cd "$$dir"; \
4039
$(RM) *.out *.gb *.smt2; \
4140
cd ..; \
4241
fi \
4342
done
43+
$(RM) tests*.log

regression/cprover/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ test-no-p:
1010
@../test.pl -e -c '../../../src/cprover/cprover'
1111

1212
clean:
13+
find . -name '*.out' -execdir $(RM) '{}' \;
1314
$(RM) tests.log

regression/goto-bmc/Makefile

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
default: tests.log
2+
3+
test:
4+
@../test.pl -e -p -c ../../../src/goto-bmc/goto-bmc
5+
6+
tests.log: ../test.pl
7+
@../test.pl -e -p -c ../../../src/goto-bmc/goto-bmc
8+
9+
clean:
10+
find . -name '*.out' -execdir $(RM) '{}' \;
11+
find . -name '*.gb' -execdir $(RM) '{}' \;
12+
$(RM) tests.log
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
default: tests.log
2+
3+
include ../../../src/config.inc
4+
include ../../../src/common
5+
6+
GOTO_BMC_EXE=../../../../src/goto-bmc/goto-bmc
7+
8+
ifeq ($(BUILD_ENV_),MSVC)
9+
GOTO_CC_EXE=../../../../src/goto-cc/goto-cl
10+
is_windows=true
11+
else
12+
GOTO_CC_EXE=../../../../src/goto-cc/goto-cc
13+
is_windows=false
14+
endif
15+
16+
test:
17+
@../../test.pl -e -p -c "../chain.sh $(GOTO_CC_EXE) $(GOTO_BMC_EXE) $(is_windows)"
18+
19+
tests.log: ../test.pl
20+
@../../test.pl -e -p -c "../chain.sh $(GOTO_CC_EXE) $(GOTO_BMC_EXE) $(is_windows)"
21+
22+
clean:
23+
find . -name '*.out' -execdir $(RM) '{}' \;
24+
find . -name '*.gb' -execdir $(RM) {} \;
25+
$(RM) tests.log

0 commit comments

Comments
 (0)