Merge pull request #3879 from tautschnig/deprecation-integer2unsigned

Use numeric_cast_v<unsigned> instead to_ulong with incompatible types [blocks: #3800]

Author: tautschnig

src/goto-instrument/accelerate/acceleration_utils.cpp

@@ -1235,7 +1235,7 @@ void acceleration_utilst::extract_polynomial(
     std::map<exprt, int> degrees;
 
     mp_integer mp=binary2integer(concrete_term.get_value().c_str(), true);
-    monomial.coeff=mp.to_long();
+    monomial.coeff = numeric_cast_v<int>(mp);
 
     if(monomial.coeff==0)
     {

src/util/arith_tools.cpp

@@ -231,7 +231,7 @@ mp_integer power(const mp_integer &base,
     case 2:
       {
         mp_integer result;
-        result.setPower2(exponent.to_ulong());
+        result.setPower2(numeric_cast_v<unsigned>(exponent));
         return result;
       }
     case 1: return 1;

src/util/ieee_float.cpp

@@ -8,7 +8,6 @@ Author: Daniel Kroening, [email protected]
 
 #include "ieee_float.h"
 
-#include <cstdint>
 #include <ostream>
 #include <cmath>
 #include <limits>
@@ -1242,11 +1241,7 @@ float ieee_floatt::to_float() const
       return std::numeric_limits<float>::quiet_NaN();
   }
 
-  mp_integer i=pack();
-  CHECK_RETURN(i.is_ulong());
-  CHECK_RETURN(i <= std::numeric_limits<std::uint32_t>::max());
-
-  a.i=i.to_ulong();
+  a.i = numeric_cast_v<uint32_t>(pack());
   return a.f;
 }