Complete MMIO rewrites before removing unused functions

__CPROVER_mm_io_{r,w} functions are unused until rewrites via mm_io are
done, which is only done when processing the input program by CBMC.
remove_unused_functions would spuriously remove the implementation of
these function, even when they may be needed. Therefore, run mm_io
instrumentation before removing unused functions.

Author: tautschnig

regression/cbmc/mm_io1/test.desc

@@ -1,7 +1,7 @@
 CORE
 main.c
 --no-standard-checks
-^Replaced MMIO operations: 3 reads, 1 writes
+^Replaced MMIO operations: 3 read\(s\), 1 write\(s\)
 ^EXIT=0$
 ^SIGNAL=0$
 ^VERIFICATION SUCCESSFUL$

src/goto-instrument/goto_instrument_parse_options.cpp

@@ -29,6 +29,7 @@ Author: Daniel Kroening, [email protected]
 #include <goto-programs/label_function_pointer_call_sites.h>
 #include <goto-programs/link_to_library.h>
 #include <goto-programs/loop_ids.h>
+#include <goto-programs/mm_io.h>
 #include <goto-programs/parameter_assignments.h>
 #include <goto-programs/read_goto_binary.h>
 #include <goto-programs/remove_calls_no_body.h>
@@ -899,6 +900,7 @@ int goto_instrument_parse_optionst::doit()
     if(cmdline.isset("drop-unused-functions"))
     {
       do_indirect_call_and_rtti_removal();
+      mm_io(goto_model, ui_message_handler);
 
       log.status() << "Removing unused functions" << messaget::eom;
       remove_unused_functions(goto_model.goto_functions, ui_message_handler);