fix conversions between long and long long

kroening · kroening · commit 8db67b9edc7c · 2023-11-27T10:17:59.000-08:00
as_long in external_sat.cpp was declared as long long, computed as long, and
subsequently passed to labs, which expects a long.  This yields an error on
any platform where long is not long long.

This changes the calculation to use long long consistently.
diff --git a/src/solvers/sat/external_sat.cpp b/src/solvers/sat/external_sat.cpp
@@ -119,8 +119,8 @@ external_satt::resultt external_satt::parse_result(std::string solver_output)
       {
         try
         {
-          signed long long as_long = std::stol(assignment_string);
-          size_t index = std::labs(as_long);
+          signed long long as_long = std::stoll(assignment_string);
+          size_t index = std::llabs(as_long);
 
           if(index >= number_of_variables)
           {

Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,8 @@ external_satt::resultt external_satt::parse_result(std::string solver_output)`
`119`	`119`	`{`
`120`	`120`	`try`
`121`	`121`	`{`
`122`		`- signed long long as_long = std::stol(assignment_string);`
`123`		`- size_t index = std::labs(as_long);`
	`122`	`+ signed long long as_long = std::stoll(assignment_string);`
	`123`	`+ size_t index = std::llabs(as_long);`
`124`	`124`
`125`	`125`	`if(index >= number_of_variables)`
`126`	`126`	`{`