Merge pull request #4746 from diffblue/clang-8-ci

switch codebuild from clang 7 to clang 8

Author: peterschrammel

buildspec-linux-clang.yml

@@ -11,20 +11,26 @@ phases:
       java: openjdk8
     commands:
       - sed -i 's#/archive.ubuntu.com#/us-east-1.ec2.archive.ubuntu.com#g' /etc/apt/sources.list
+      - wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add -
+      - add-apt-repository 'deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-8 main'
       - apt-get update -y
-      - apt-get install -y clang-7 flex bison make git libwww-perl patch ccache libc6-dev-i386 jq
+      - apt-get install -y clang-8 flex bison make git libwww-perl patch ccache libc6-dev-i386 jq gdb
   build:
     commands:
       - echo Build started on `date`
-      - git submodule update --init --recursive
-      - make -C src CXX='ccache /usr/bin/clang++-7' CXX_FLAGS='-Qunused-arguments'
-      - make -C jbmc/src CXX='ccache /usr/bin/clang++-7' CXX_FLAGS='-Qunused-arguments'
+      - make -C src minisat2-download
+      - make -C jbmc/src setup-submodules
+      - make -C src CXX='ccache /usr/bin/clang++-8' CXX_FLAGS='-Qunused-arguments' -j2
+      - make -C unit CXX='ccache /usr/bin/clang++-8' CXX_FLAGS='-Qunused-arguments' -j2
+      - make -C jbmc/src CXX='ccache /usr/bin/clang++-8' CXX_FLAGS='-Qunused-arguments' -j2
+      - make -C jbmc/unit CXX='ccache /usr/bin/clang++-8' CXX_FLAGS='-Qunused-arguments' -j2
   post_build:
     commands:
-      - make -C unit test CXX='ccache /usr/bin/clang++-7' CXX_FLAGS='-Qunused-arguments'
-      - make -C regression test
+      - make -C unit test
+      - make -C regression test CXX='ccache /usr/bin/clang++-8' CXX_FLAGS='-Qunused-arguments'
+      - make -C regression/cbmc test-paths-lifo
       - env PATH=$PATH:`pwd`/src/solvers make -C regression/cbmc test-cprover-smt2
-      - make -C jbmc/unit test CXX='ccache /usr/bin/clang++-7' CXX_FLAGS='-Qunused-arguments'
+      - make -C jbmc/unit test
       - make -C jbmc/regression test
       - echo Build completed on `date`
 cache:

src/solvers/strings/string_builtin_function.h

@@ -19,6 +19,7 @@ class string_constraint_generatort;
 class string_builtin_functiont
 {
 public:
+  string_builtin_functiont() = delete;
   string_builtin_functiont(const string_builtin_functiont &) = delete;
   virtual ~string_builtin_functiont() = default;
 
@@ -60,9 +61,6 @@ class string_builtin_functiont
     return true;
   }
 
-private:
-  string_builtin_functiont() = default;
-
 protected:
   array_poolt &array_pool;