Skip to content

Ready for v0.1.1 PyPI/GitHub release #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 of 8 tasks
cadenmyers13 opened this issue Oct 23, 2024 · 16 comments
Closed
7 of 8 tasks

Ready for v0.1.1 PyPI/GitHub release #31

cadenmyers13 opened this issue Oct 23, 2024 · 16 comments

Comments

@cadenmyers13
Copy link
Contributor

cadenmyers13 commented Oct 23, 2024

Release checklist for GitHub contributors

  • All PRs/issues attached to the release are merged.
  • All the badges on the README are passing. (assigned to @bobleesj)
  • License information is verified as correct. If you are unsure, please comment below.
  • Locally rendered documentation contains all appropriate pages, including API references (check no modules are
    missing), tutorials (no tutorial in diffpy.fourigui, and other human-written text is up-to-date with any changes in the code.
  • Installation instructions in the README, documentation and on the website (this should be handled after release) (e.g., diffpy.org) are updated and tested
  • Successfully run any tutorial examples or do functional testing in some other way. Add tutorial for diffpy.fourigui #40
  • links on README are working Fix documentation links in README #33
  • Grammar and writing quality have been checked (no typos).

Please mention @sbillinge when you are ready for release. Include any additional comments necessary, such as
version information and details about the pre-release.

@sbillinge
Copy link
Contributor

Thanks @cadenmyers13 please ping me again when all the items are completed.

@cadenmyers13
Copy link
Contributor Author

@bobleesj Following the README, when I install with conda install diffpy.fourigui I get the installation error that diffpy.fourigui is not available on conda-forge. However, it install with pip install diffpy.fourigui. Is this because this package isn't on conda-forge?

@bobleesj
Copy link
Contributor

@cadenmyers13 for conda-forge, yes. We currently have it under the rcpre-release channel.

@sbillinge sbillinge changed the title Ready for v0.1.0rc3 PyPI/GitHub release Ready for v0.1.1rc3 PyPI/GitHub release Oct 23, 2024
@sbillinge
Copy link
Contributor

@cadenmyers13 I changed this to 0.1.1 in the title. This is the checklist for the next release so we want to bump the number. We will do a pre-release (so there wil be an rc0) but it will be 0.1.1rc0 but I don't think we need a separate checklist for the rc's

@sbillinge sbillinge changed the title Ready for v0.1.1rc3 PyPI/GitHub release Ready for v0.1.1 PyPI/GitHub release Oct 23, 2024
@sbillinge
Copy link
Contributor

@cadenmyers13 I added issues that we want to close on this release to the 0.1.1 release milestone.

@bobleesj
Copy link
Contributor

@sbillinge

Could you please setup codecov token for diffpy.fourigui? Appears diffpy.fourigui has not been configured as expected: https://app.codecov.io/gh/diffpy

Screenshot 2024-10-23 at 8 12 52 PM

@sbillinge
Copy link
Contributor

OK, not sure how to do this. I thought I configured it correctly and added the CODECOV_TOKEN to the repo, but for some reason the upload to codecov step is being skipped in the CI workflow, and no coverage is uploaded.

@bobleesj
Copy link
Contributor

@cadenmyers13 Just to note the codecov badge works. Thanks @sbillinge!

@cadenmyers13
Copy link
Contributor Author

@sbillinge Can I get a verification that the licensing is correct for this package?

@sbillinge
Copy link
Contributor

@sbillinge Can I get a verification that the licensing is correct for this package?

yes, can confirm. I checked that on the list.

@cadenmyers13
Copy link
Contributor Author

@sbillinge @bobleesj Once the opened PRs are confirmed and merged we should be good to release

@sbillinge
Copy link
Contributor

@sbillinge @bobleesj Once the opened PRs are confirmed and merged we should be good to release

in other words, we are not ready for release. Please let me know when we are.....

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Nov 11, 2024

All issues and PRs associated with package content have been closed and content is up to date with current cookiecutter standard. New issue (#65) has been created for support of python 3.13.

@bobleesj
Copy link
Contributor

@cadenmyers13 Please provide a bit more context on why this issue is closed while we have a checklist for 0.2.0 being created. #65 (comment)

I recall 0.1.1 was simply for recutting and 0.2.0 would be recutting + supporting py 3.13

@cadenmyers13
Copy link
Contributor Author

@cadenmyers13 Please provide a bit more context on why this issue is closed while we have a checklist for 0.2.0 being created. #65 (comment)

I recall 0.1.1 was simply for recutting and 0.2.0 would be recutting + supporting py 3.13

comment has been updated^

@sbillinge
Copy link
Contributor

Closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants