Skip to content

Implement multiple options for computing muD #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 4 tasks
Tracked by #145
yucongalicechen opened this issue Dec 13, 2024 · 0 comments
Open
2 of 4 tasks
Tracked by #145

Implement multiple options for computing muD #143

yucongalicechen opened this issue Dec 13, 2024 · 0 comments
Milestone

Comments

@yucongalicechen
Copy link
Collaborator

yucongalicechen commented Dec 13, 2024

We would like an app that reads things from the command line (or gooey), calls the functions from here, and goes on its merry way. Its tricky in gooey but we may be able to do one layer of conditional logic, to support a gooey uc like this:

  • UC3a
  1. user selects "compute muD from known density" radio button
  2. labpdfproc.mudCalc presents a form pre-filled with defaults containing fields for user to enter mass density in g/cm^3, composition (e.g. ZrO2), wavelength(angstroms), D (mm). Defaults are <Till's zirconia number>, , , 1.
  3. user enters the other info (browses for files etc.)
  4. user hits start
  5. code runs.
  • UC3b - user has muD
  1. user selects "enter muD manually"
  2. mudCalc presents a box to type in a float "muD value"
  3. as UC3a 3-end
  • UC3c - user doesn't know density
  1. user selects "estimate muD from composition"
  2. labpdfproc.mudCalc presents a form pre-filled with defaults containing fields for user to enter powder fraction (number between 0 and 1), composition (e.g. ZrO2), wavelength(angstroms), D (mm). Defaults are 0.5, , , 1. program assumes some reasonable atomic number density by default, since this is not known or given in principle.
  3. as UC3a 3-end
  • UC4
  1. as UC3a.1-2
  2. user clicks run calc
  3. lpp.mudCalc returns the calculated value as output without running the cve calc.

Implementationally, one way to handle 3a-c in lpp might be that it is not conditional but depending on which fields are filled vs empty different logic is run. It means that some defaults would have to be None.

See more dicussions in diffpy/diffpy.utils#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant