Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workflow for getting wavelength/anode type #161

Closed
Tracked by #145
yucongalicechen opened this issue Jan 29, 2025 · 1 comment · Fixed by #162
Closed
Tracked by #145

feat: workflow for getting wavelength/anode type #161

yucongalicechen opened this issue Jan 29, 2025 · 1 comment · Fixed by #162
Milestone

Comments

@yucongalicechen
Copy link
Collaborator

Refer to #155 for more discussion.

Try to get wavelength/anode type from args, then from config files.
C1: User specified nothing. If mu*D is given and xtype is tth, proceed. Otherwise, throw an error.
C2: User specified both, throw an error.
C3: User specified anode type. Check if it is in the database. If not throw an error.
C4: User specified wavelength. Check if it is valid. If not throw an error.

@yucongalicechen
Copy link
Collaborator Author

@till-schertenleib this is kind of the new workflow to get wavelength/anode type from users. Does this make more sense to you more? We decide not to give a default value but just let them enter either wavelength or anode type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant