Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: muD fast calculation for values <0.5 and >6 #167

Open
Tracked by #145
yucongalicechen opened this issue Feb 7, 2025 · 1 comment
Open
Tracked by #145

feat: muD fast calculation for values <0.5 and >6 #167

yucongalicechen opened this issue Feb 7, 2025 · 1 comment
Milestone

Comments

@yucongalicechen
Copy link
Collaborator

yucongalicechen commented Feb 7, 2025

Problem

Proposed solution

  • Do not raise an error when muD < 0.5.
  • Include muD up to 7 for fast calculation.
  • Report user muD when we raise the error, e.g. "muD=8 is outside the range of 0.5<=muD<=7, please rerun the program..."
@yucongalicechen yucongalicechen added this to the 0.2.1 release milestone Feb 7, 2025
@sbillinge
Copy link
Contributor

why are we going from 6 to 7? This seems pretty arbitrary. I think it is more a philosophical issue about how to handle this flow. We can define mud_threshold for example. Right now mud_threshold = 6. We could change mud_threshold to something else, but the conversation here might be better to be about what flow we want whenmud_threshold is exceeded in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants