-
Notifications
You must be signed in to change notification settings - Fork 11
USE CASES - getmud module #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
[simon edited comment after Yucong edits]: This looks good, though I am not a huge fan of the cli you propose as this is a huge amount of typing at the command line. Can we not decide the method to use at the back end based on the information provided? something like
or altrernatively
or altrernatively
We can work on the wording a bit, but something like that seems easier to use? As well as suggestions for D given composition and energy, the users may want muD after they have loaded their capilllary. If they measured density they can use #2 above, but if they didn't we could offer them:
|
@sbillinge Could you check the UCs I updated in the top comment based on our conversation today? Thanks. I have closed a few other issues as they were a bit outdated and confusing. |
One final thought. If it were me I would be a bit lazy and not want to run
and have it compute mud and run the correction. It can assume a packing fraction of 0.5 but allow this to be overwritten? |
Problem
(Replace #166, I'm starting from UC1 again for numbering)
UC1: Compute mu and diameter
mu
for a fully dense sample.UC2: Compute diameter from target muD
UC3: Compute muD from zscan
UC4: Compute muD theoretically
We also need CLI and GUI interface for each UC. They might look like:
labpdfproc getmud compute_mu_and_diameter -s <sample_composition> -e <energy>
labpdfproc getmud compute_diameter_from_mud -s <sample_composition> -e <energy> -p <packing_fraction> -m <target_muD>
labpdfproc getmud compute_mud_from_zscan -z <zscan_file>
labpdfproc getmud compute_theoretical_mud -s <sample_composition> -e <energy> -m <mass_density> -d <diameter>
(Check feat: getmud UC1 (get_diameter) #184 for a previous implementation of CLI. Check Regolith main.py)
Proposed solution
The text was updated successfully, but these errors were encountered: