fix: re-cookie with scikit-package v0.1.0
#165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 18 18
Lines 795 795
=======================================
Hits 770 770
Misses 25 25
|
|
@bobleesj @sbillinge It's ready for review, thank you! |
There was a problem hiding this comment.
Thanks @ycexiao please see inline comments
@Sparks29032 @bobleesj @Tieqiong please can you take a quick look at this? Like PDFgui, this has a manual that uses texinfo. This may need different handling in general than standard docs as we have been discussing with @Tieqiong. I think there are a few decisions ot make:
- migrate away from texinfo so we don't have to deal with this any more in the future in all projects
- as 1 but just for pdfmorph, whose manual may not be so extensive atm
- stay with texinfo and make a new workflow that handles this in all our projects.
- something else
@ycexiao please can you organize a meeting with everyone listed and let's each of us bring a 5 minute pitch of which option we advocate for, then we can discuss to consensus....
| ;; Frobenius norm used in np.linalg.norm | ||
| fro | ||
|
|
||
| ;; library used for Python package release, no longer used |
There was a problem hiding this comment.
This is more a question for @bobleesj but why is this here? Presumably we want to remove all references to rever if we are not using it any more, so having codespell flag it is helpful?
There was a problem hiding this comment.
@ycexiao Could you try to remove the rever keyword and see if pre-commit still passes?
There was a problem hiding this comment.
the point of the linting is to make the code better, so we want it to fail when that allows us to make the code better. Just a general comment.
There was a problem hiding this comment.
I removed rever and codespell raise an error
codespell................................................................Failed
- hook id: codespell
- exit code: 65
CHANGELOG.rst:70: rever ==> revert, refer, feverIn the CHANGELOG.txt 70, there is
v0.0.1
====================
**Changed:**
* Fixed rever GH address
I think adding the words ignore here is necessary. It lets .codespell check other contents in the CHANGELOG.txt.
| recommended that you consult online resources and become somewhat | ||
| familiar before using PDFmorph. | ||
|
|
||
| PDFmorph can be run with Python 3.10 or higher. It makes use of several third party |
There was a problem hiding this comment.
@ycexiao please can you make an issue to have @Sparks29032 revisit this readme and bring it up to date and remove unwanted stuff
|
@ycexiao Overall good work considering this is your first time running It appears that the |
Sorry, but I want to ask what do we use to render docs? |
I see. I rendered the documents locally and it doesn't perform well. I will fix this later. |
do you mean you will make an issue and fix it on a separate PR? Or will you close this PR and make a new PR without the path changes in the docs? Please see my comment about working with @Tieqiong on the docs. We will probably move away from using texinfo for docs and so all those changes should be on a separate PR. To avoid a large diff could we redo this PR without those changes? Sorry about that. |
These path changes are not related to |
close #159