wx12 and bonlengthdialog (#142)

* wx12 and bonlengthdialog

* devutils/makedist import order

Author: sbillinge

devutils/makesdist

@@ -11,11 +11,11 @@ import subprocess
 import sys
 import tarfile
 
+from setup import FALLBACK_VERSION, versiondata
+
 BASEDIR = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
 sys.path.insert(0, BASEDIR)
 
-from setup import FALLBACK_VERSION, versiondata
-
 timestamp = versiondata.getint("DEFAULT", "timestamp")
 
 vfb = versiondata.get("DEFAULT", "version").split(".post")[0] + ".post0"

src/diffpy/pdfgui/gui/bondlengthdialog.py

@@ -219,8 +219,8 @@ def onSpin(self, event):  # wxGlade: BondLengthDialog.<event_handler>
         loop = True
         while loop:
             loop = False
-            for l in letters:
-                if newval == getattr(self, l):
+            for letter in letters:
+                if newval == getattr(self, letter):
                     loop = True
                     if increasing:
                         newval += 1

src/diffpy/pdfgui/gui/wxextensions/wx12.py

@@ -46,7 +46,7 @@ def Append(self, *args, **kwargs):
 
 
 if WX4:
-    Menu = wx.Menu
+    Menu = wx.Menu  # noqa: F811
 
 # ----------------------------------------------------------------------------
 
@@ -58,7 +58,7 @@ class ListCtrl(wx.ListCtrl):
 
 
 if WX4:
-    ListCtrl = wx.ListCtrl
+    ListCtrl = wx.ListCtrl  # noqa: F811
 
 # ----------------------------------------------------------------------------
 
@@ -70,7 +70,7 @@ class TreeCtrl(wx.TreeCtrl):
 
 
 if WX4:
-    TreeCtrl = wx.TreeCtrl
+    TreeCtrl = wx.TreeCtrl  # noqa: F811
 
 # wx.ToolBar -----------------------------------------------------------------