Skip to content

Fix the workaround for removing test depreciation warning in PR#170 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobleesj opened this issue Aug 20, 2024 · 6 comments
Closed

Comments

@bobleesj
Copy link
Contributor

History:

Improvement:

  • The merged PR fixes depreciation warning and runs tests.
  • It was discussed during a meeting (@sbillinge) that we want to clean up (remove files) and reduce technical debt.
@sbillinge
Copy link
Contributor

I think we just need to bring everything up to cookiecutter standards for running tests here?

@sbillinge sbillinge added this to the v3.1.0 milestone Aug 20, 2024
@bobleesj
Copy link
Contributor Author

@bobleesj cookiecut this

@bobleesj bobleesj changed the title Fix the workaround for removing test deprecation warning in PR#170 Fix the workaround for removing test depreciation warning in PR#170 Sep 30, 2024
@bobleesj
Copy link
Contributor Author

@Tieqiong can we close this? The major change seems to be migrating from pkg_resources to importlib.resources to parse values such as version, etc. Are there any remaining things to check or do?

@Tieqiong
Copy link
Contributor

Tieqiong commented Sep 30, 2024

@bobleesj This issue is good to go as long as pip install . and pip install -e . both pass pytest

@bobleesj
Copy link
Contributor Author

@bobleesj This issue is good to go as long as pip install . and pip install -e . both pass pytest

Yup works. @sbillinge could you please close this issue?

@sbillinge
Copy link
Contributor

Closed as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants