Skip to content

Windows Python 3.11, 3.12 matrix CI fail due to ImportError: DLL load failed while importing pdffit2 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobleesj opened this issue Dec 7, 2024 · 1 comment · Fixed by #240 or diffpy/diffpy.pdffit2#111

Comments

@bobleesj
Copy link
Contributor

bobleesj commented Dec 7, 2024

Problem

Screenshot 2024-12-07 at 3 01 13 PM

Windows Python 3.11 and 3.12 fail due to ImportError: DLL load failed while importing pdffit2

Ref: https://github.com/diffpy/diffpy.pdfgui/actions/runs/12215530301/job/34077576222

In our CI, since we are also testing pdffit, we install pdfgui using the following methods:

          conda install --file requirements/test.txt
          conda install wxpython diffpy.utils matplotlib-base
          pip install diffpy.pdffit2==1.4.4rc6
          python -m pip install . --no-deps

using the installation method above, I was able to run pdfgui via macOS ARM64.

Proposed solution

But I recall this was a problem back then. @sbillinge @Tieqiong any insights on this DLL lad import problem?

I will have access to a windows laptop in the next 2-3 days or so.

@bobleesj bobleesj changed the title Windows Python 3.11, 3.12 CI fails due to ImportError: DLL load failed while importing pdffit2 Windows Python 3.11, 3.12 matrix CI fail due to ImportError: DLL load failed while importing pdffit2 Dec 7, 2024
@sbillinge
Copy link
Contributor

I thought the problems we had with windows were finding gsl during the build. @Tieqiong so you remember this problem?

We could try and solve it out just jump to the full 3.13 and work on everything together? Install pdffit2 from conda-forge and see if that fixes it?

@sbillinge sbillinge added this to the v3.1.0 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants