Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the package with example data #128

Open
bobleesj opened this issue Oct 30, 2024 · 5 comments
Open

Test the package with example data #128

bobleesj opened this issue Oct 30, 2024 · 5 comments

Comments

@bobleesj
Copy link
Contributor

Problem

The current package does not provide example data while the main app below requires input_directory

def main():
    args = create_parser()
    if args.input_directory is None:
        args.input_directory = Path.cwd()
    grid, input_data = load_input_signals(args.input_directory)

Proposed solution

We can attempt to use test data nmf_mapping from https://github.com/diffpy/diffpy.nmf_mapping/blob/main/diffpy/nmf_mapping/tests/data and see whether the code works.

@bobleesj bobleesj changed the title Test the package with real data Test the package with example data Oct 30, 2024
@bobleesj
Copy link
Contributor Author

Noticed that data are provided under examples/mix___ZnSe-w_0.4___BaTiO3_c-w_0.6 Have you tried running the package with these data? @Fil158

@sbillinge
Copy link
Contributor

if the data are small, we can add it to the repo to make it easy for users.

@Fil158
Copy link

Fil158 commented Nov 7, 2024

image

This error occurs when I try with those data

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 7, 2024

Yes, I had reproduced the error before. It is because the code wasn't tested using real files/data.

As of now, our current priority is to implement/interpret the snmf algo

@sbillinge
Copy link
Contributor

Also, I suggest when we work on this issue, let's change the filename of the example data to something more readable and easy to type......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants