-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the package with example data #128
Comments
Noticed that data are provided under |
if the data are small, we can add it to the repo to make it easy for users. |
Yes, I had reproduced the error before. It is because the code wasn't tested using real files/data. As of now, our current priority is to implement/interpret the snmf algo |
Also, I suggest when we work on this issue, let's change the filename of the example data to something more readable and easy to type...... |
Problem
The current package does not provide example data while the main app below requires
input_directory
Proposed solution
We can attempt to use test data nmf_mapping from https://github.com/diffpy/diffpy.nmf_mapping/blob/main/diffpy/nmf_mapping/tests/data and see whether the code works.
The text was updated successfully, but these errors were encountered: