Skip to content

Commit 4064168

Browse files
committed
conversion from python2 to python3 language
1 parent 011fa4c commit 4064168

12 files changed

+79
-73
lines changed

Diff for: diffpy/srmise/applications/extract.py

+19-19
Original file line numberDiff line numberDiff line change
@@ -277,21 +277,21 @@ def main():
277277
from diffpy.srmise import peaks
278278
try:
279279
options.peakfunction = eval("peaks."+options.peakfunction)
280-
except Exception, err:
281-
print err
282-
print "Could not create peak function '%s'. Exiting." \
283-
%options.peakfunction
280+
except Exception as err:
281+
print(err)
282+
print("Could not create peak function '%s'. Exiting." \
283+
%options.peakfunction)
284284
return
285285

286286
if options.modelevaluator is not None:
287287
from diffpy.srmise import modelevaluators
288288
try:
289289
options.modelevaluator = \
290290
eval("modelevaluators."+options.modelevaluator)
291-
except Exception, err:
292-
print err
293-
print "Could not find ModelEvaluator '%s'. Exiting." \
294-
%options.modelevaluator
291+
except Exception as err:
292+
print(err)
293+
print ("Could not find ModelEvaluator '%s'. Exiting." \
294+
%options.modelevaluator)
295295
return
296296

297297
if options.bcrystal is not None:
@@ -328,9 +328,9 @@ def main():
328328
from diffpy.srmise import baselines
329329
try:
330330
options.baseline = eval("baselines."+options.baseline)
331-
except Exception, err:
332-
print err
333-
print "Could not create baseline '%s'. Exiting." %options.baseline
331+
except Exception as err:
332+
print(err)
333+
print("Could not create baseline '%s'. Exiting." %options.baseline)
334334
return
335335

336336
filename = args[0]
@@ -392,22 +392,22 @@ def main():
392392
if options.savefile is not None:
393393
try:
394394
ext.write(options.savefile)
395-
except SrMiseFileError, err:
396-
print err
397-
print "Could not save result to '%s'." %options.savefile
395+
except SrMiseFileError as err:
396+
print(err)
397+
print("Could not save result to '%s'." %options.savefile)
398398

399399

400400
if options.pwafile is not None:
401401
try:
402402
ext.writepwa(options.pwafile)
403-
except SrMiseFileError, err:
404-
print err
405-
print "Could not save pwa summary to '%s'." %options.pwafile
403+
except SrMiseFileError as err:
404+
print(err)
405+
print("Could not save pwa summary to '%s'." %options.pwafile)
406406

407407

408-
print ext
408+
print(ext)
409409
if cov is not None:
410-
print cov
410+
print(cov)
411411

412412
if options.plot:
413413
from diffpy.srmise.applications.plot import makeplot

Diff for: diffpy/srmise/applications/plot.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import sys
1717

1818
import matplotlib.pyplot as plt
19+
from matplotlib.pyplot import MultipleLocator
1920
import mpl_toolkits.axisartist as AA
2021
import numpy as np
2122
from mpl_toolkits.axes_grid1 import make_axes_locatable
@@ -147,7 +148,7 @@ def labelallsubplots():
147148
s = "(%s)" % c
148149
ht = plt.text(0.04, 0.95, s,
149150
horizontalalignment='left', verticalalignment='top',
150-
transform=gca().transAxes, weight='bold')
151+
transform=plt.gca().transAxes, weight='bold')
151152
rv.append(ht)
152153
return rv
153154

@@ -478,7 +479,7 @@ def readcompare(filename):
478479
# TODO: Make this safer
479480
try:
480481
datastring = open(filename,'rb').read()
481-
except Exception, err:
482+
except Exception as err:
482483
raise err
483484

484485
import re
@@ -491,8 +492,8 @@ def readcompare(filename):
491492
try:
492493
for line in datastring.split("\n"):
493494
distances.append(float(line))
494-
except (ValueError, IndexError), err:
495-
print "Could not read distances from '%s'. Ignoring file." %filename
495+
except (ValueError, IndexError) as err:
496+
print("Could not read distances from '%s'. Ignoring file." %filename)
496497

497498
if len(distances) == 0:
498499
return None
@@ -539,14 +540,14 @@ def main():
539540
try:
540541
toplot.load(filename)
541542
except Exception:
542-
print "File '%s' is not a .srmise or PeakStability data file." %filename
543+
print("File '%s' is not a .srmise or PeakStability data file." %filename)
543544
return
544545

545546
if opts.model is not None:
546547
try:
547548
toplot.setcurrent(opts.model)
548549
except (Exception):
549-
print "Ignoring model, %s is not a PeakStability file." %filename
550+
print("Ignoring model, %s is not a PeakStability file." %filename)
550551

551552
distances = None
552553
if opts.compare is not None:

Diff for: diffpy/srmise/basefunction.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import logging
1616
import re
1717
import sys
18-
18+
from fontTools.unicode import Unicode
1919
import numpy as np
2020

2121
from diffpy.srmise.modelparts import ModelPart, ModelParts
@@ -90,7 +90,7 @@ def __init__(self, parameterdict, parformats, default_formats, metadict, base=No
9090
# arbitrary types, parameters are indexed by these keys as well as
9191
# integer indices. Restricting keys to strings keeps things sane.
9292
for p in self.parameterdict.keys():
93-
if type(p) not in (str, unicode):
93+
if type(p) not in (str, Unicode):
9494
emsg = "Argument parameterdict's keys must be strings."
9595
raise ValueError(emsg)
9696
vals = self.parameterdict.values()
@@ -377,7 +377,7 @@ def factory(functionstr, baselist):
377377
for (k, v) in ddict.items():
378378
try:
379379
pdict[k] = eval(v)
380-
except Exception, e:
380+
except Exception as e:
381381
logger.exception(e)
382382
emsg = ("Invalid parameter: %s=%s" %(k,v))
383383
raise SrMiseDataFormatError(emsg)
@@ -451,7 +451,7 @@ def safefunction(f, fsafe):
451451

452452
pt = TerminationRipples(p, 20)
453453
outstr2 = pt.writestr([p])
454-
print outstr
454+
print(outstr)
455455

456456
pt2 = BaseFunction.factory(outstr2, [p])
457-
print type(pt2)
457+
print(type(pt2))

Diff for: diffpy/srmise/dataclusters.py

+8-3
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,11 @@ def animate(self):
376376
status = self.status
377377
self.reset_clusters()
378378

379+
fig, ax = plt.subplots()
380+
canvas = fig.canvas
381+
background = canvas.copy_from_bbox(ax.bbox)
382+
ymin, ymax = ax.get_ylim()
383+
379384
all_lines = []
380385
for i in self:
381386
canvas.restore_region(background)
@@ -411,9 +416,9 @@ def animate(self):
411416
testcluster = DataClusters(x, y, .1)
412417
testcluster.makeclusters()
413418

414-
print testcluster.clusters
419+
print(testcluster.clusters)
415420
adj = testcluster.find_adjacent_clusters()
416-
print adj
421+
print(adj)
417422
if len(adj) >0:
418423
testcluster.combine_clusters(adj)
419-
print testcluster.clusters
424+
print(testcluster.clusters)

Diff for: diffpy/srmise/modelcluster.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ def factory(mcstr, **kwds):
666666
emsg = ("Number of value fields does not match that given by '%s'" %start_data_info)
667667
for a, v in zip(arrays, line.split()):
668668
a.append(float(v))
669-
except (ValueError, IndexError), err:
669+
except (ValueError, IndexError) as err:
670670
raise SrMiseDataFormatError(err)
671671
if hasr:
672672
r_data = np.array(r_data)
@@ -875,7 +875,7 @@ def fit(self, justify=False, ntrials=0, fitbaseline=False, estimate=True, cov=No
875875
if estimate:
876876
try:
877877
self.estimatepeak()
878-
except SrMiseEstimationError, e:
878+
except SrMiseEstimationError as e:
879879
logger.info("Fit: No model to fit, estimation not possible.")
880880
return
881881
else:
@@ -906,7 +906,7 @@ def fit(self, justify=False, ntrials=0, fitbaseline=False, estimate=True, cov=No
906906
ntrials,
907907
cov,
908908
cov_format)
909-
except SrMiseFitError, e:
909+
except SrMiseFitError as e:
910910
logger.debug("Error while fitting cluster: %s\nReverting to original model.", e)
911911
self.model = orig_model
912912
self.baseline = orig_baseline
@@ -1413,13 +1413,13 @@ def prune(self):
14131413
guess_peaks = Peaks([pf.actualize(p, "pwa") for p in guesspars])
14141414
cluster = ModelCluster(guess_peaks, None, r, y, err, None, AICc, [pf])
14151415

1416-
print "--- Actual Peak parameters ---"
1417-
print ideal_peaks
1416+
print("--- Actual Peak parameters ---")
1417+
print(ideal_peaks)
14181418

1419-
print "\n--- Before fit ---"
1420-
print cluster
1419+
print("\n--- Before fit ---")
1420+
print(cluster)
14211421

14221422
cluster.fit()
14231423

1424-
print "\n--- After fit ---"
1425-
print cluster
1424+
print("\n--- After fit ---")
1425+
print(cluster)

Diff for: diffpy/srmise/modelparts.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ def fit(self, r, y, y_error, range=None, ntrials=0, cov=None, cov_format="defaul
150150
plt.draw()
151151

152152
if srmiselog.wait:
153-
print "Press 'Enter' to continue...",
154-
raw_input()
153+
print("Press 'Enter' to continue...",)
154+
input()
155155

156156
if f[4] not in (1,2,3,4):
157157
emsg = "Fit did not succeed -- " + str(f[3])

Diff for: diffpy/srmise/multimodelselection.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def eatkwds(*args, **kwds):
2727
"""Convenience function to remove all keywords in args from kwds."""
2828
for k in args:
2929
if k in kwds:
30-
print "Keyword %s=%s ignored." %(k, kwds.pop(k))
30+
print("Keyword %s=%s ignored." %(k, kwds.pop(k)))
3131
return kwds
3232

3333
class MultimodelSelection(PeakStability):
@@ -77,7 +77,7 @@ def makeaics(self, dgs, dr, filename=None):
7777
(r, y, dr, dy) = self.ppe.resampledata(dr)
7878

7979
for model_idx in range(len(self.results)):
80-
print "Testing model %s of %s." %(model_idx, len(self.results))
80+
print("Testing model %s of %s." %(model_idx, len(self.results)))
8181

8282
result = self.results[model_idx]
8383
em = self.ppe.error_method
@@ -208,7 +208,7 @@ def animate_probs(self, step=False, duration=0., **kwds):
208208
plt.ion()
209209
plt.draw()
210210
if step:
211-
raw_input()
211+
input()
212212
if duration > 0:
213213
time.sleep(sleeptime)
214214

@@ -269,7 +269,7 @@ def animate_classprobs(self, step=False, duration=0., **kwds):
269269
plt.ion()
270270
plt.draw()
271271
if step:
272-
raw_input()
272+
input()
273273
if duration > 0:
274274
time.sleep(sleeptime)
275275

Diff for: diffpy/srmise/pdfdataset.py

+12-12
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def read(self, filename):
150150
"""
151151
try:
152152
self.readStr(open(filename,'rb').read())
153-
except PDFDataFormatError, err:
153+
except PDFDataFormatError as err:
154154
basename = os.path.basename(filename)
155155
emsg = ("Could not open '%s' due to unsupported file format " +
156156
"or corrupted data. [%s]") % (basename, err)
@@ -274,7 +274,7 @@ def readStr(self, datastring):
274274
self.drobs = len(self.robs) * [0.0]
275275
if not has_dGobs:
276276
self.dGobs = len(self.robs) * [0.0]
277-
except (ValueError, IndexError), err:
277+
except (ValueError, IndexError) as err:
278278
raise PDFDataFormatError(err)
279279
self.rmin = self.robs[0]
280280
self.rmax = self.robs[-1]
@@ -378,21 +378,21 @@ class PDFDataFormatError(Exception):
378378
filename = sys.argv[1]
379379
dataset = PDFDataSet("test")
380380
dataset.read(filename)
381-
print "== metadata =="
381+
print("== metadata ==")
382382
for k, v in dataset.metadata.iteritems():
383-
print k, "=", v
384-
print "== data members =="
383+
print(k, "=", v)
384+
print("== data members ==")
385385
for k, v in dataset.__dict__.iteritems():
386386
if k in ('metadata', 'robs', 'Gobs', 'drobs', 'dGobs') or k[0] == "_":
387387
continue
388-
print k, "=", v
389-
print "== robs Gobs drobs dGobs =="
388+
print(k, "=", v)
389+
print("== robs Gobs drobs dGobs ==")
390390
for i in range(len(dataset.robs)):
391-
print dataset.robs[i], dataset.Gobs[i], dataset.drobs[i], dataset.dGobs[i]
392-
print "== writeStr() =="
393-
print dataset.writeStr()
394-
print "== datasetcopy.writeStr() =="
391+
print(dataset.robs[i], dataset.Gobs[i], dataset.drobs[i], dataset.dGobs[i])
392+
print("== writeStr() ==")
393+
print(dataset.writeStr())
394+
print("== datasetcopy.writeStr() ==")
395395
datasetcopy = dataset.copy()
396-
print datasetcopy.writeStr()
396+
print(datasetcopy.writeStr())
397397

398398
# End of file

Diff for: diffpy/srmise/pdfpeakextraction.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,7 @@ def find_qmax(r, y, showgraphs=False):
913913

914914
plt.show()
915915
plt.ioff()
916-
raw_input()
916+
input()
917917

918918
return (qmax, dq)
919919

Diff for: diffpy/srmise/peakextraction.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ def read(self, filename):
255255
"""
256256
try:
257257
self.readstr(open(filename,'rb').read())
258-
except SrMiseDataFormatError, err:
258+
except SrMiseDataFormatError as err:
259259
logger.exception("")
260260
basename = os.path.basename(filename)
261261
emsg = ("Could not open '%s' due to unsupported file format " +
@@ -443,7 +443,7 @@ def readstr(self, datastring):
443443
emsg = ("Number of value fields does not match that given by '%s'" %start_data_info)
444444
for a, v in zip(arrays, line.split()):
445445
a.append(float(v))
446-
except (ValueError, IndexError), err:
446+
except (ValueError, IndexError) as err:
447447
raise SrMiseDataFormatError(str(err))
448448
if hasx:
449449
self.x = np.array(self.x)
@@ -1212,11 +1212,11 @@ def fit_single(self):
12121212
te.setvars(rng=[1.51,10.], pf=[pf], cres=.1, effective_dy = 1.5*err)
12131213
te.extract_single()
12141214

1215-
print "--- Actual Peak parameters ---"
1216-
print ideal_peaks
1215+
print("--- Actual Peak parameters ---")
1216+
print(ideal_peaks)
12171217

1218-
print "\n--- After extraction ---"
1219-
print te
1218+
print("\n--- After extraction ---")
1219+
print(te)
12201220

12211221
te.plot()
1222-
raw_input()
1222+
input()

0 commit comments

Comments
 (0)