Skip to content

Commit f31d3d4

Browse files
fix broken import, remove deprecated pkg_resource (#50)
1 parent c1886a1 commit f31d3d4

File tree

4 files changed

+19
-17
lines changed

4 files changed

+19
-17
lines changed

Diff for: src/diffpy/srmise/basefunction.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ def factory(functionstr, baselist):
369369
# "key=value"->{"key":"value"}
370370
data = re.split(r"(?:[\r\n]+|\A)(\S+)=", data)
371371
ddict = {}
372-
for i in range(len(data) / 2):
372+
for i in range(len(data) // 2):
373373
ddict[data[2 * i + 1]] = data[2 * i + 2]
374374

375375
# dictionary of parameters
@@ -442,7 +442,8 @@ def safefunction(f, fsafe):
442442

443443
if __name__ == "__main__":
444444

445-
from diffpy.srmise.peaks import GaussianOverR, TerminationRipples
445+
from diffpy.srmise.peaks.gaussianoverr import GaussianOverR
446+
from diffpy.srmise.peaks.terminationripples import TerminationRipples
446447

447448
p = GaussianOverR(0.8)
448449
outstr = p.writestr([])

Diff for: src/diffpy/srmise/modelcluster.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
import numpy as np
2727

2828
from diffpy.srmise import srmiselog
29-
from diffpy.srmise.baselines import Baseline
29+
from diffpy.srmise.baselines.base import Baseline
3030
from diffpy.srmise.modelparts import ModelParts
31-
from diffpy.srmise.peaks import Peak, Peaks
31+
from diffpy.srmise.peaks.base import Peak, Peaks
3232
from diffpy.srmise.srmiseerrors import (
3333
SrMiseDataFormatError,
3434
SrMiseEstimationError,

Diff for: src/diffpy/srmise/modelparts.py

+10-9
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,22 @@
2020
"""
2121

2222
import logging
23+
from importlib.metadata import version
2324

2425
import matplotlib.pyplot as plt
2526
import numpy as np
2627

2728
# Output of scipy.optimize.leastsq for a single parameter changed in scipy 0.8.0
2829
# Before it returned a scalar, later it returned an array of length 1.
29-
import pkg_resources as pr
30+
from packaging.version import parse
3031
from scipy.optimize import leastsq
3132

3233
from diffpy.srmise import srmiselog
3334
from diffpy.srmise.srmiseerrors import SrMiseFitError, SrMiseStaticOwnerError, SrMiseUndefinedCovarianceError
3435

3536
logger = logging.getLogger("diffpy.srmise")
36-
__spv__ = pr.get_distribution("scipy").version
37-
__oldleastsqbehavior__ = pr.parse_version(__spv__) < pr.parse_version("0.8.0")
37+
__spv__ = version("scipy")
38+
__oldleastsqbehavior__ = parse(__spv__) < parse("0.8.0")
3839

3940

4041
class ModelParts(list):
@@ -123,8 +124,8 @@ def fit(
123124
freepars, # initial parameters
124125
args=args, # arguments to residual, residual_jacobian
125126
Dfun=self.residual_jacobian, # explicit Jacobian
126-
col_deriv=1, # order of derivatives in Jacobian
127-
full_output=1,
127+
col_deriv=True, # order of derivatives in Jacobian
128+
full_output=True,
128129
maxfev=ntrials,
129130
)
130131
except NotImplementedError:
@@ -136,8 +137,8 @@ def fit(
136137
self.residual, # minimize this function
137138
freepars, # initial parameters
138139
args=args, # arguments to residual
139-
col_deriv=1, # order of derivatives in Jacobian
140-
full_output=1,
140+
col_deriv=True, # order of derivatives in Jacobian
141+
full_output=True,
141142
maxfev=ntrials,
142143
)
143144
except Exception:
@@ -202,7 +203,7 @@ def fit(
202203
try:
203204
cov.transform(in_format="internal", out_format=cov_format)
204205
except SrMiseUndefinedCovarianceError:
205-
logger.warn("Covariance not defined. Fit may not have converged.")
206+
logger.warning("Covariance not defined. Fit may not have converged.")
206207

207208
return
208209

@@ -352,7 +353,7 @@ def __str__(self):
352353

353354
def __getslice__(self, i, j):
354355
"""Extends list.__getslice__"""
355-
return self.__class__(list.__getslice__(self, i, j))
356+
return self.__class__(list.__getitem__(self, i, j))
356357

357358
def transform(self, in_format="internal", out_format="internal"):
358359
"""Transforms format of parameters in this modelpart.

Diff for: src/diffpy/srmise/pdfdataset.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def readStr(self, datastring):
201201

202202
# find where the metadata starts
203203
metadata = ""
204-
res = re.search(r"^#+\ +metadata\b\n", header, re.M)
204+
res = re.search(r"^#+ +metadata\b\n", header, re.M)
205205
if res:
206206
metadata = header[res.end() :]
207207
header = header[: res.start()]
@@ -343,7 +343,7 @@ def writeStr(self):
343343
# metadata
344344
if len(self.metadata) > 0:
345345
lines.append("# metadata")
346-
for k, v in self.metadata.iteritems():
346+
for k, v in self.metadata.items():
347347
lines.append("%s=%s" % (k, v))
348348
# write data:
349349
lines.append("##### start data")
@@ -408,10 +408,10 @@ class PDFDataFormatError(Exception):
408408
dataset = PDFDataSet("test")
409409
dataset.read(filename)
410410
print("== metadata ==")
411-
for k, v in dataset.metadata.iteritems():
411+
for k, v in dataset.metadata.items():
412412
print(k, "=", v)
413413
print("== data members ==")
414-
for k, v in dataset.__dict__.iteritems():
414+
for k, v in dataset.__dict__.items():
415415
if k in ("metadata", "robs", "Gobs", "drobs", "dGobs") or k[0] == "_":
416416
continue
417417
print(k, "=", v)

0 commit comments

Comments
 (0)