Skip to content

GaussianOverR object has no attribute createpeak #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevenhua0320 opened this issue Aug 14, 2024 · 2 comments
Closed

GaussianOverR object has no attribute createpeak #65

stevenhua0320 opened this issue Aug 14, 2024 · 2 comments

Comments

@stevenhua0320
Copy link
Contributor

When running terminationripples, it raises error
ideal_peaks = Peaks([pf1.createpeak(p, "pwa") for p in pars])
^^^^^^^^^^^^^^
AttributeError: 'GaussianOverR' object has no attribute 'createpeak'

@Ainamacar
Copy link
Contributor

I believe all calls to createpeak() should be replaced by calls to actualize() . They all occur in very, very old tests that I evidently stopped running before this name change. (No doubt, this was sloppy of me.) The files are:

  • baselines/base.py
  • peaks/terminationripples.py
  • peaks/gaussian.py
  • peaks/gaussianoverr.py

Note that throughout the code, all test code in blocks like if __name__ == '__main__': are not vital to the functioning of SrMise itself. In the end most of these should probably be removed as proper tests are written.

@stevenhua0320
Copy link
Contributor Author

Closed by PR #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants