Recude chance of errors in SpaceGroup repr test

Signed-off-by: Håkon Wiik Ånes <[email protected]>

Author: hakonanes

src/diffpy/structure/tests/testspacegroups.py

@@ -88,30 +88,40 @@ def test__hashSymOpList(self):
 
     def test_spacegroup_representation(self):
         """Verify SpaceGroup.__repr__()."""
-        numbers = [1, 3, 16, 75, 143, 168, 229]
-        short_names = ["P1", "P2", "P222", "P4", "P3", "P6", "Im-3m"]
-        systems = [
-            "Triclinic",
-            "Monoclinic",
-            "Orthorhombic",
-            "Tetragonal",
-            "Trigonal",
-            "Hexagonal",
-            "Cubic",
-        ]
-        n_symmetry_matrices = [1, 2, 4, 4, 3, 6, 96]
-        n_point_symmetry_matrices = [1, 2, 4, 4, 3, 6, 48]
-        sg_dict = dict(zip(
-            numbers,
-            zip(short_names, systems, n_symmetry_matrices, n_point_symmetry_matrices)
-        ))
-        for key, value in sg_dict.items():
-            sg = GetSpaceGroup(key)
-            expected_str = (
-                               "SpaceGroup #%i (%s, %s). Symmetry matrices: %i, "
-                               "point sym. matr.: %i"
-                           ) % ((key,) + value)
-            self.assertEqual(sg.__repr__(), expected_str)
+        self.assertEqual(
+            repr(GetSpaceGroup(1)),
+            "SpaceGroup #1 (P1, Triclinic). Symmetry matrices: 1, point sym. matr.: 1"
+        )
+        self.assertEqual(
+            repr(GetSpaceGroup(3)),
+            "SpaceGroup #3 (P2, Monoclinic). Symmetry matrices: 2, point sym. matr.: 2"
+        )
+        self.assertEqual(
+            repr(GetSpaceGroup(16)),
+            (
+                "SpaceGroup #16 (P222, Orthorhombic). Symmetry matrices: 4, point sym. "
+                "matr.: 4"
+            )
+        )
+        self.assertEqual(
+            repr(GetSpaceGroup(75)),
+            "SpaceGroup #75 (P4, Tetragonal). Symmetry matrices: 4, point sym. matr.: 4"
+        )
+        self.assertEqual(
+            repr(GetSpaceGroup(143)),
+            "SpaceGroup #143 (P3, Trigonal). Symmetry matrices: 3, point sym. matr.: 3"
+        )
+        self.assertEqual(
+            repr(GetSpaceGroup(168)),
+            "SpaceGroup #168 (P6, Hexagonal). Symmetry matrices: 6, point sym. matr.: 6"
+        )
+        self.assertEqual(
+            repr(GetSpaceGroup(229)),
+            (
+                "SpaceGroup #229 (Im-3m, Cubic). Symmetry matrices: 96, point sym. "
+                "matr.: 48"
+            )
+        )
         return
 
 # End of class TestRoutines