Skip to content

setuptools-git-versioning dependency #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlaehne opened this issue Aug 22, 2024 · 3 comments
Closed

setuptools-git-versioning dependency #96

jlaehne opened this issue Aug 22, 2024 · 3 comments

Comments

@jlaehne
Copy link

jlaehne commented Aug 22, 2024

Is there an important reason to pin setuptools-git-versioning<2?

requires = ["setuptools>=62.0", "setuptools-git-versioning<2"]

It builds with v2 on my system.

@sbillinge
Copy link
Contributor

@Sparks29032 or anyone know why we did this?

@Sparks29032
Copy link
Contributor

We did that before version 2 came out in case version 2 breaks everything. Great it works on 2, let's upgrade!

@bobleesj
Copy link
Contributor

Let's close this since we've implemented setuptools-git-versioning>=2.0 both here #102 and the cookiecutter repo.

@jlaehne jlaehne closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants